You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/19 18:14:49 UTC

[GitHub] [airflow] potiuk opened a new pull request, #23094: Fix artifact for MyPy checks

potiuk opened a new pull request, #23094:
URL: https://github.com/apache/airflow/pull/23094

   Occasionally MyPy detects errors which have not been detected
   before. We will need to fix it permanently soon but for now this
   should fix the main errors.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #23094: Fix artifact for MyPy checks

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23094:
URL: https://github.com/apache/airflow/pull/23094#issuecomment-1102963157

   Hey @ashb  - I think I figured out why the MyPy "instability" happens and updated the PR to fix it permanently.
   
   I think it has to do with the number of files and the fact that it's semi-random how pre-commit splits files if it decides to split long list of files in two commands.
   
   This PR now makes the split "consistent" - it splits the files to check into "core" and "providers" buckets. Which sooner or later we will have to do anyway when/if we split repos.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #23094: Fix artifact for MyPy checks

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23094:
URL: https://github.com/apache/airflow/pull/23094


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #23094: Fix artifact for MyPy checks

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #23094:
URL: https://github.com/apache/airflow/pull/23094#issuecomment-1102966016

   Ohh right yeah that would explain it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] github-actions[bot] commented on pull request #23094: Fix artifact for MyPy checks

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23094:
URL: https://github.com/apache/airflow/pull/23094#issuecomment-1102947881

   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #23094: Fix artifact for MyPy checks

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23094:
URL: https://github.com/apache/airflow/pull/23094#issuecomment-1102995079

   Passed static checks. Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org