You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2015/06/16 20:26:01 UTC
[jira] [Commented] (THRIFT-1025) C++ ServerSocket should inherit
from Socket with the necessary Ctor to listen on connections from a
specific host (similar to perl library)
[ https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588512#comment-14588512 ]
James E. King, III commented on THRIFT-1025:
--------------------------------------------
I went back and looked at ServerSocket in perl and the listen() routine is explicitly passing undef as the host, which means any interface. I don't think the perl ServerSocket has the implementation to listen to a single port in 0.9.2. I opened another ticket for this, THRIFT-3189, and it will be addressed as part of adding a proper SSLSocket and SSLServerSocket.
> C++ ServerSocket should inherit from Socket with the necessary Ctor to listen on connections from a specific host (similar to perl library)
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1025
> URL: https://issues.apache.org/jira/browse/THRIFT-1025
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Environment: any
> Reporter: Valery Kreidenko
> Assignee: James E. King, III
> Fix For: 0.9.3
>
> Attachments: THRIFT-1025.patch
>
>
> Perl library ServerSocket inherits from Socket the ctor ServerSocket->new( addr, port) which enables to accept the connections from specified host only (for security reasons for instance).
> package Thrift::ServerSocket;
> use Socket qw(IPPROTO_TCP TCP_NODELAY);
> use base qw( Thrift::Socket Thrift::ServerTransport );
> while surprisingly C++ ServerSocket omits inheriting from Socket.
> class TServerSocket : public TServerTransport {
> Regards.
> Valery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)