[GitHub] [arrow-rs] alamb commented on a change in pull request #837: fix parquet_derive with default features (and fix `cargo publish`)

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #837:
URL: https://github.com/apache/arrow-rs/pull/837#discussion_r730812099



##########
File path: parquet_derive/test/dependency/README.md
##########
@@ -0,0 +1,21 @@
+<!---

Review comment:
       this follows the pattern of the tests in `arrow/test/dependency`

##########
File path: parquet/Cargo.toml
##########
@@ -54,8 +54,8 @@ snap = "1.0"
 brotli = "3.3"
 flate2 = "1.0"
 lz4 = "1.23"
-arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT" }

Review comment:
       this use of arrow with default features as a `dev` dependency masked the problem with parquet_derive in tests. 

##########
File path: parquet/Cargo.toml
##########
@@ -41,7 +41,7 @@ lz4 = { version = "1.23", optional = true }
 zstd = { version = "0.9", optional = true }
 chrono = "0.4"
 num-bigint = "0.4"
-arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT", optional = true, default-features = false }
+arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT", optional = true, default-features = false, features = ["ipc"] }

Review comment:
       This is the fix of the actual problem: the arrow writer requires the `ipc` feature which is no longer a default




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org