You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by "hufeng@apache" <hu...@apache.org> on 2021/08/09 11:35:13 UTC
[VOTE]: Release Apache dubbo-js v4.0.1
Hello Dubbo/Dubbo Js Community,
This is a call for vote to release Apache dubbo-js version v4.0.1.
The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/4.0.1/
Git tag for the release:
https://github.com/apache/dubbo-js/blob/v4.0.1/CHANGE.md
Hash for the release tag:
6c195408f80926bbe88726d03ef6d4277fab54dc
The artifacts have been signed with Key :6C763D903EC3BDC3 , which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS
The vote will be open for at least 72 hours or until the necessary number
of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo-js Team
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by Albumen Kevin <al...@apache.org>.
+1 binding,
I checked
[√ ] Do the contents of the release match with what's tagged in version
control?
[√ ] Are there any unexpected binary files in the release?
[√ ] Do LICENSE and NOTICE files exist?
[√ ] Is the LICENSE and NOTICE text correct?
[√ ] Are release files in the correct location?
[√ ] Are the digital signatures and hashes correct?
[√ ] the NOTICE year correct
[√ ] Can you compile from source? Are the instructions clear?
[√ ] All uts pass
On Tue, Aug 10, 2021 at 11:37 PM feng hu <fe...@gmail.com> wrote:
> Hi Justin Mclean,
>
> The problem has been fixed, svn had committed the latest package.
>
> Kind Regards,
> hufeng
>
> feng hu <fe...@gmail.com> 于2021年8月10日周二 下午6:23写道：
>
> > Hi,
> >
> > Thanks for helping check, let me fix these problems
> >
> > Kind Regards,
> > hufeng
> >
> > Justin Mclean <ju...@classsoftware.com> 于2021年8月10日周二 下午3:36写道：
> >
> >> Hi,
> >>
> >> Sorry it’s -1 (binding) from me.
> >>
> >> I think you might want to repackage the release as it unpacks to
> >> "Users/hufeng/Desktop/“
> >>
> >> I checked:
> >> - signature and hashes are fine
> >> - LICENSE is missing some information or some files have the wrong
> headers
> >> - NOTICE is a little ahead of itself (2022!)
> >> - A number of files have "Copyright 1999-2018 Alibaba Group Holding
> Ltd.”
> >> in their header, either this is incorrect or something is missing from
> >> LICENSE. This files also seem to have double headers.
> >> - No unexpected binary files
> >>
> >> Kind Regards,
> >> Justin
> >
> >
>
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by feng hu <fe...@gmail.com>.
Hi Justin Mclean,
The problem has been fixed, svn had committed the latest package.
Kind Regards,
hufeng
feng hu <fe...@gmail.com> 于2021年8月10日周二 下午6:23写道：
> Hi,
>
> Thanks for helping check, let me fix these problems
>
> Kind Regards,
> hufeng
>
> Justin Mclean <ju...@classsoftware.com> 于2021年8月10日周二 下午3:36写道：
>
>> Hi,
>>
>> Sorry it’s -1 (binding) from me.
>>
>> I think you might want to repackage the release as it unpacks to
>> "Users/hufeng/Desktop/“
>>
>> I checked:
>> - signature and hashes are fine
>> - LICENSE is missing some information or some files have the wrong headers
>> - NOTICE is a little ahead of itself (2022!)
>> - A number of files have "Copyright 1999-2018 Alibaba Group Holding Ltd.”
>> in their header, either this is incorrect or something is missing from
>> LICENSE. This files also seem to have double headers.
>> - No unexpected binary files
>>
>> Kind Regards,
>> Justin
>
>
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by feng hu <fe...@gmail.com>.
Hi,
Thanks for helping check, let me fix these problems
Kind Regards,
hufeng
Justin Mclean <ju...@classsoftware.com> 于2021年8月10日周二 下午3:36写道：
> Hi,
>
> Sorry it’s -1 (binding) from me.
>
> I think you might want to repackage the release as it unpacks to
> "Users/hufeng/Desktop/“
>
> I checked:
> - signature and hashes are fine
> - LICENSE is missing some information or some files have the wrong headers
> - NOTICE is a little ahead of itself (2022!)
> - A number of files have "Copyright 1999-2018 Alibaba Group Holding Ltd.”
> in their header, either this is incorrect or something is missing from
> LICENSE. This files also seem to have double headers.
> - No unexpected binary files
>
> Kind Regards,
> Justin
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Sorry it’s -1 (binding) from me.
I think you might want to repackage the release as it unpacks to "Users/hufeng/Desktop/“
I checked:
- signature and hashes are fine
- LICENSE is missing some information or some files have the wrong headers
- NOTICE is a little ahead of itself (2022!)
- A number of files have "Copyright 1999-2018 Alibaba Group Holding Ltd.” in their header, either this is incorrect or something is missing from LICENSE. This files also seem to have double headers.
- No unexpected binary files
Kind Regards,
Justin
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by joezou <jo...@apache.org>.
+1 binding
Checked
[√] All uts passed.
[√] CHANGE.md .
[√] License headers .
[√] Download links are fine.
stocks alex <al...@apache.org> 于2021年8月23日周一 上午10:40写道：
> +1 binding
>
> I have checked the following options.
> [√ ] Do the contents of the release match with what's tagged in version
> control?
> [√ ] Are there any unexpected binary files in the release?
> [√ ] Do LICENSE and NOTICE files exist?
> [√ ] Is the LICENSE and NOTICE text correct?
> [√ ] Are the digital signatures and hashes correct?
> [√ ] the NOTICE year correct
>
>
>
> Jun Liu <li...@apache.org> 于2021年8月17日周二 下午1:18写道：
>
> > +1 binding
> >
> > I have checked:
> > * Signature and hash are good
> > * Issues like unpack directory, copyright year, unexpected license
> header
> > fixed
> > * Release notes looks fine
> >
> > I didn’t compile and run the code for I am not really good at javascript
> > development.
> >
> > Jun
> >
> > > On Aug 9, 2021, at 7:35 PM, hufeng@apache <hu...@apache.org> wrote:
> > >
> > > Hello Dubbo/Dubbo Js Community,
> > >
> > > This is a call for vote to release Apache dubbo-js version v4.0.1.
> > >
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/4.0.1/
> > >
> > > Git tag for the release:
> > > https://github.com/apache/dubbo-js/blob/v4.0.1/CHANGE.md
> > >
> > > Hash for the release tag:
> > > 6c195408f80926bbe88726d03ef6d4277fab54dc
> > >
> > > The artifacts have been signed with Key :6C763D903EC3BDC3 , which can
> be
> > > found in the keys file:
> > >
> > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> number
> > > of
> > > votes are reached.
> > >
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > > Thanks,
> > >
> > > The Apache Dubbo-js Team
> >
> >
>
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by stocks alex <al...@apache.org>.
+1 binding
I have checked the following options.
[√ ] Do the contents of the release match with what's tagged in version
control?
[√ ] Are there any unexpected binary files in the release?
[√ ] Do LICENSE and NOTICE files exist?
[√ ] Is the LICENSE and NOTICE text correct?
[√ ] Are the digital signatures and hashes correct?
[√ ] the NOTICE year correct
Jun Liu <li...@apache.org> 于2021年8月17日周二 下午1:18写道：
> +1 binding
>
> I have checked:
> * Signature and hash are good
> * Issues like unpack directory, copyright year, unexpected license header
> fixed
> * Release notes looks fine
>
> I didn’t compile and run the code for I am not really good at javascript
> development.
>
> Jun
>
> > On Aug 9, 2021, at 7:35 PM, hufeng@apache <hu...@apache.org> wrote:
> >
> > Hello Dubbo/Dubbo Js Community,
> >
> > This is a call for vote to release Apache dubbo-js version v4.0.1.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/4.0.1/
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo-js/blob/v4.0.1/CHANGE.md
> >
> > Hash for the release tag:
> > 6c195408f80926bbe88726d03ef6d4277fab54dc
> >
> > The artifacts have been signed with Key :6C763D903EC3BDC3 , which can be
> > found in the keys file:
> >
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> > Thanks,
> >
> > The Apache Dubbo-js Team
>
>
Re: [VOTE]: Release Apache dubbo-js v4.0.1
Posted by Jun Liu <li...@apache.org>.
+1 binding
I have checked:
* Signature and hash are good
* Issues like unpack directory, copyright year, unexpected license header fixed
* Release notes looks fine
I didn’t compile and run the code for I am not really good at javascript development.
Jun
> On Aug 9, 2021, at 7:35 PM, hufeng@apache <hu...@apache.org> wrote:
>
> Hello Dubbo/Dubbo Js Community,
>
> This is a call for vote to release Apache dubbo-js version v4.0.1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/4.0.1/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v4.0.1/CHANGE.md
>
> Hash for the release tag:
> 6c195408f80926bbe88726d03ef6d4277fab54dc
>
> The artifacts have been signed with Key :6C763D903EC3BDC3 , which can be
> found in the keys file:
>
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
>
> Please vote accordingly:
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thanks,
>
> The Apache Dubbo-js Team