You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hans Duedal (JIRA)" <ji...@apache.org> on 2011/09/22 15:38:26 UTC
[jira] [Created] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Switch to performance branch, get rid of BinaryParser
-----------------------------------------------------
Key: THRIFT-1353
URL: https://issues.apache.org/jira/browse/THRIFT-1353
Project: Thrift
Issue Type: Improvement
Components: Node.js - Library
Affects Versions: 0.7
Reporter: Hans Duedal
Fix For: 0.8
I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca updated THRIFT-1353:
--------------------------------------
Attachment: (was: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch)
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274755#comment-13274755 ]
Henrique Mendonca commented on THRIFT-1353:
-------------------------------------------
Thanks for you feedback Wade. I think we should check this in as it fix some bugs and improve other stuff. Got your code to run but didn't manage to create a proper patch (too many files and other conflicts). I also don't work directly with it, only had some ideas which would require it, so it's also hard for me to dedicate time for it. However, I should get this running within the next weeks.
Thanks for your contribution anyway!
Henrique
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Wade Simmons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113032#comment-13113032 ]
Wade Simmons commented on THRIFT-1353:
--------------------------------------
I'm the author of this upstream branch (and the original author of the Node.js support). I plan to spend some time this weekend working on getting a patch made from this branch so we can get it merged upstream. There are a few things that aren't backwards compatible, so we will need to make sure that is properly described in the 0.8 release.
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.8
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca resolved THRIFT-1353.
---------------------------------------
Resolution: Fixed
Assignee: Henrique Mendonca (was: Roger Meier)
finally committed!
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Tom Jack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410936#comment-13410936 ]
Tom Jack commented on THRIFT-1353:
----------------------------------
Is there a reason to both include the files from node-int64 and to depend on it in package.json?
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "John Eckhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485056#comment-13485056 ]
John Eckhart commented on THRIFT-1353:
--------------------------------------
Looks good now, thanks!
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Jake Farrell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell reassigned THRIFT-1353:
------------------------------------
Assignee: Jake Farrell
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Jake Farrell
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234850#comment-13234850 ]
Jake Farrell commented on THRIFT-1353:
--------------------------------------
Henrique, ill take a look at this patch later tonight. Roger or I can see about getting node tests setup within jenkins
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190346#comment-13190346 ]
Roger Meier commented on THRIFT-1353:
-------------------------------------
Your repo does not reflect the complete Thrift codebase, e.g. compiler is missing. I recommend you to fork from the Apache Thrift github mirror located at https://github.com/apache/thrift. This will simplify code sync and enable better alignment of the two JavaScript implementations and nodejs imrovements... we did also a lot of changes on the compiler! the other thing is the testsuite, see THRIFT-1134
It is really difficult to manage a project with so many languages and that's why unit test and cross language tests are so important, see THRIFT-847 => test/test.sh integrates also some node cross language tests
I really like to merge your stuff in, but I need a patch and whenever possible unit tests.
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.9
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "John Eckhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484550#comment-13484550 ]
John Eckhart commented on THRIFT-1353:
--------------------------------------
I appreciate that you can't copy that file without following your process; however, I am pointing out that your most recent merge missed a file and therefore broke the node client. The missing file is also in the patch that the original author attached to the ticket after following the contribution process.
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Jake Farrell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell reassigned THRIFT-1353:
------------------------------------
Assignee: Roger Meier (was: Jake Farrell)
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Wade Simmons (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121349#comment-13121349 ]
Wade Simmons commented on THRIFT-1353:
--------------------------------------
I merged node-thrift 0.7.0 with my performance branch, and plan to submit to Thrift for 0.8.0. Can I get a few people to test this?
* `thrift-dev` on npm
* https://github.com/wadey/node-thrift/tree/performance
You will need this compiler patch:
https://issues.apache.org/jira/browse/THRIFT-1351
Two non-backwords compatible changes:
* "binary" fields will be returned as Buffers instead of Strings
* "int64" fields will be returned as http://github.com/broofa/node-int64 objects
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.8
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484864#comment-13484864 ]
Hudson commented on THRIFT-1353:
--------------------------------
Integrated in Thrift #576 (See [https://builds.apache.org/job/Thrift/576/])
Thrift-1353: Switch to performance branch, get rid of BinaryParser
Client: Node.js
Patch: Wade Simmons
add missing files and licenses (Revision 1402414)
Result = ABORTED
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Wade Simmons (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190177#comment-13190177 ]
Wade Simmons commented on THRIFT-1353:
--------------------------------------
All of the feedback I've heard is positive. Can we get this merged in?
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.9
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484622#comment-13484622 ]
Jake Farrell commented on THRIFT-1353:
--------------------------------------
Sorry John, didnt understand what your comment was implying. Henrique can you please take a look at this as you where the committer
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1353) Switch to performance branch, get rid
of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca closed THRIFT-1353.
-------------------------------------
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Henrique Mendonca (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca updated THRIFT-1353:
--------------------------------------
Attachment: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
I had a look on Wade's changes ages ago and they seemed to be very nicely done. Since he seems to be no longer reachable I'm submitting the re-based patch in his name. Plus some minor changes on the tests.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
This fixes the problems with Int64 as well as improves the buffered transport impl. and also remove the use of the slow binary parser as he says above.
There is still a lot to do on the nodejs library but this is a great addiction. Could anyone test/commit this?
By the way, does anyone knows how we can install node on the jenkins slave?
Cheers!
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (THRIFT-1353) Switch to performance branch,
get rid of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399278#comment-13399278 ]
Henrique Mendonca edited comment on THRIFT-1353 at 6/22/12 12:04 PM:
---------------------------------------------------------------------
Here it is, finally.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
cleaned up and rebased for today's trunk
It also includes the files from node-int64
ps: the test from cpp client to nodejs server still fails but we're getting there...
ps2: rewriting the nodejs test client to use the assert module would be also nice...
ps3: patch with -p0 please
was (Author: henrique):
Here it is, finally.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
cleaned up and rebased for today's trunk
It also includes the files from node-int64
ps: the test from cpp client to nodejs server still fails but we're getting there...
ps2: rewriting the nodejs test client to use the assert module would be also nice...
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Wade Simmons (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274738#comment-13274738 ]
Wade Simmons commented on THRIFT-1353:
--------------------------------------
Henrique Mendonca: Thanks for pushing forward on getting this merged in. I am no longer using Node.js and Thrift at work, so I have a hard time finding time to give to this effort. I'll step back and let those that are actively using this make the decisions, although you can reach out to me if there any specific questions about my original code that needs answering.
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "John Eckhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484508#comment-13484508 ]
John Eckhart commented on THRIFT-1353:
--------------------------------------
Looks like you missed a file (binary.js) which is not the same as binary_parser.js that is in the release branch. Here's a link to the original file: https://raw.github.com/wadey/node-thrift/performance/lib/thrift/binary.js
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411300#comment-13411300 ]
Henrique Mendonca commented on THRIFT-1353:
-------------------------------------------
Not really, just wanted to facilitate it for the committers and testers. Talked briefly to Roger before but I wasn't sure whether Jenkins would handle the NPM. We can definitely leave the files from node-int64 uncommitted if it works.
Thanks for having a look anyways!
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482092#comment-13482092 ]
Hudson commented on THRIFT-1353:
--------------------------------
Integrated in Thrift #571 (See [https://builds.apache.org/job/Thrift/571/])
Thrift-1353: Switch to performance branch, get rid of BinaryParser
Client: Node.js
Patch: Wade Simmons
"binary" fields will be returned as Buffers instead of Strings
"int64" fields will be returned as http://github.com/broofa/node-int64 objects (Revision 1401081)
Result = ABORTED
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484542#comment-13484542 ]
Jake Farrell commented on THRIFT-1353:
--------------------------------------
John, We can not copy files from github and just add them to the codebase due to legal rights, please see http://thrift.apache.org/docs/HowToContribute/ for details on making contributions
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Henrique Mendonca
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca updated THRIFT-1353:
--------------------------------------
Attachment: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
Here it is, finally.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
cleaned up and rebased for today's trunk
It also includes the files from node-int64
ps: the test from cpp client to nodejs server still fails but we're getting there...
ps2: rewriting the nodejs test client to use the assert module would be also nice...
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112799#comment-13112799 ]
Roger Meier commented on THRIFT-1353:
-------------------------------------
Hi Hans!
Thanks for bringing new ideas and bugfixes to Thrift Node.js implementation!
Could you please create a patch and grant License to ASF?
see: http://wiki.apache.org/thrift/HowToContribute
Another important topic are Unit Tests, see my comments on THRIFT-1261
do you have some?
I'm looking forward to commit patches for Node.js!
Thanks
roger
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.8
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira