You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/04 16:09:04 UTC
(superset) 01/01: fix: Results section in Explore shows an infinite spinner (#27366)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 4972fbe751b2c27d665e1cc5882c19c946a2b282
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Mon Mar 4 08:15:55 2024 -0500
fix: Results section in Explore shows an infinite spinner (#27366)
(cherry picked from commit 231e659b56617fcdefa7534e14ffcfe50a8c084c)
---
.../plugins/legacy-plugin-chart-heatmap/src/transformProps.js | 8 ++++----
.../src/explore/components/DataTablesPane/DataTablesPane.tsx | 3 ++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js
index f58c58b724..ddafe456a6 100644
--- a/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js
+++ b/superset-frontend/plugins/legacy-plugin-chart-heatmap/src/transformProps.js
@@ -58,14 +58,14 @@ export default function transformProps(chartProps) {
coltypes[0] === GenericDataType.TEMPORAL
? getTimeFormatter(timeFormat)
: coltypes[0] === GenericDataType.Numeric
- ? Number
- : String;
+ ? Number
+ : String;
const yAxisFormatter =
coltypes[1] === GenericDataType.TEMPORAL
? getTimeFormatter(timeFormat)
: coltypes[1] === GenericDataType.Numeric
- ? Number
- : String;
+ ? Number
+ : String;
return {
width,
height,
diff --git a/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx b/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
index 726f3ea468..60b65c6ffc 100644
--- a/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
+++ b/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
@@ -123,7 +123,8 @@ export const DataTablesPane = ({
if (
panelOpen &&
activeTabKey.startsWith(ResultTypes.Results) &&
- chartStatus === 'rendered'
+ chartStatus &&
+ chartStatus !== 'loading'
) {
setIsRequest({
results: true,