You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/10 07:59:12 UTC

[GitHub] [rocketmq] KyrieChang opened a new pull request, #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

KyrieChang opened a new pull request, #4444:
URL: https://github.com/apache/rocketmq/pull/4444

   
   Broker/Namserver/Client 启动时，没有把配置打印出来，不利查问题


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #4444:
URL: https://github.com/apache/rocketmq/pull/4444#issuecomment-1152134738

   ![image](https://user-images.githubusercontent.com/58988019/173029578-873d2328-f537-482f-b5f0-86cf420972f8.png)
   
   you mean this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4444:
URL: https://github.com/apache/rocketmq/pull/4444#issuecomment-1152111923

   
   [![Coverage Status](https://coveralls.io/builds/49914621/badge)](https://coveralls.io/builds/49914621)
   
   Coverage decreased (-0.1%) to 52.103% when pulling **271681fe08c1183ea8e88c89bf80d497e5102bfd on KyrieChang:develop** into **73b9ac82bcd14b2a40ba31888a96e62d06d42d92 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
hzh0425 commented on code in PR #4444:
URL: https://github.com/apache/rocketmq/pull/4444#discussion_r894311392


##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:
##########
@@ -121,7 +121,10 @@ public static NamesrvController createNamesrvController(String[] args) throws IO
         log = InternalLoggerFactory.getLogger(LoggerName.NAMESRV_LOGGER_NAME);
 
         MixAll.printObjectProperties(log, namesrvConfig);

Review Comment:
   This has already print the config in logs, you can check the configs in namesrv_default.log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4444:
URL: https://github.com/apache/rocketmq/pull/4444#issuecomment-1152112179

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4444](https://codecov.io/gh/apache/rocketmq/pull/4444?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (271681f) into [develop](https://codecov.io/gh/apache/rocketmq/commit/73b9ac82bcd14b2a40ba31888a96e62d06d42d92?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (73b9ac8) will **increase** coverage by `0.01%`.
   > The diff coverage is `21.42%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4444      +/-   ##
   =============================================
   + Coverage      48.15%   48.16%   +0.01%     
   - Complexity      5104     5111       +7     
   =============================================
     Files            646      646              
     Lines          42911    42925      +14     
     Branches        5611     5611              
   =============================================
   + Hits           20662    20675      +13     
   - Misses         19734    19741       +7     
   + Partials        2515     2509       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/rocketmq/broker/BrokerStartup.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyU3RhcnR1cC5qYXZh) | `5.47% <0.00%> (-0.16%)` | :arrow_down: |
   | [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | `32.72% <0.00%> (-0.10%)` | :arrow_down: |
   | [.../apache/rocketmq/common/namesrv/NamesrvConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbmFtZXNydi9OYW1lc3J2Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/rocketmq/namesrv/NamesrvStartup.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9OYW1lc3J2U3RhcnR1cC5qYXZh) | `20.51% <0.00%> (-0.54%)` | :arrow_down: |
   | [...che/rocketmq/remoting/netty/NettyClientConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5Q2xpZW50Q29uZmlnLmphdmE=) | `47.36% <0.00%> (-0.85%)` | :arrow_down: |
   | [...che/rocketmq/remoting/netty/NettyServerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5U2VydmVyQ29uZmlnLmphdmE=) | `47.45% <0.00%> (-0.82%)` | :arrow_down: |
   | [...ache/rocketmq/store/config/MessageStoreConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2NvbmZpZy9NZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | `61.53% <0.00%> (-0.19%)` | :arrow_down: |
   | [...ketmq/client/consumer/DefaultLitePullConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdExpdGVQdWxsQ29uc3VtZXIuamF2YQ==) | `76.50% <100.00%> (+0.14%)` | :arrow_up: |
   | [...ocketmq/client/consumer/DefaultMQPushConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvRGVmYXVsdE1RUHVzaENvbnN1bWVyLmphdmE=) | `58.12% <100.00%> (+0.20%)` | :arrow_up: |
   | [...he/rocketmq/client/producer/DefaultMQProducer.java](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvRGVmYXVsdE1RUHJvZHVjZXIuamF2YQ==) | `58.29% <100.00%> (+0.19%)` | :arrow_up: |
   | ... and [16 more](https://codecov.io/gh/apache/rocketmq/pull/4444/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4444?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4444?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [73b9ac8...271681f](https://codecov.io/gh/apache/rocketmq/pull/4444?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] KyrieChang commented on a diff in pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
KyrieChang commented on code in PR #4444:
URL: https://github.com/apache/rocketmq/pull/4444#discussion_r894340437


##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:
##########
@@ -121,7 +121,10 @@ public static NamesrvController createNamesrvController(String[] args) throws IO
         log = InternalLoggerFactory.getLogger(LoggerName.NAMESRV_LOGGER_NAME);
 
         MixAll.printObjectProperties(log, namesrvConfig);

Review Comment:
   Wechat group posted the task, which I thought was to be printed on the console



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
hzh0425 commented on code in PR #4444:
URL: https://github.com/apache/rocketmq/pull/4444#discussion_r894341945


##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:
##########
@@ -121,7 +121,10 @@ public static NamesrvController createNamesrvController(String[] args) throws IO
         log = InternalLoggerFactory.getLogger(LoggerName.NAMESRV_LOGGER_NAME);
 
         MixAll.printObjectProperties(log, namesrvConfig);

Review Comment:
   oh，okay， good job



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] KyrieChang closed pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters

Posted by GitBox <gi...@apache.org>.
KyrieChang closed pull request #4444: [ISSUE #4443] Print broker/namserver/client startup parameters
URL: https://github.com/apache/rocketmq/pull/4444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org