You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by abisek <gi...@git.apache.org> on 2015/04/16 22:07:39 UTC
[GitHub] phoenix pull request: PHOENIX-1733: sqlline.py doesn't allow conne...
GitHub user abisek opened a pull request:
https://github.com/apache/phoenix/pull/69
PHOENIX-1733: sqlline.py doesn't allow connecting with a tenant-specific...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abisek/phoenix 4.x-HBase-0.98
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 285abcc731806cd0cabf8df0f2d3a9d3379a17d7
Author: Abhishek Sreenivasa <as...@salesforce.com>
Date: 2015-04-16T19:57:26Z
PHOENIX-1733: sqlline.py doesn't allow connecting with a tenant-specific connection
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-1733: sqlline.py doesn't allow conne...
Posted by abisek <gi...@git.apache.org>.
Github user abisek commented on the pull request:
https://github.com/apache/phoenix/pull/69#issuecomment-94068262
@gabrielreid - good catch! I updated the code to handle the shell quoting in a platform-specific manner.
I verified the changes on Unix. I'm going to try it on Windows by end of the day today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-1733: sqlline.py doesn't allow conne...
Posted by gabrielreid <gi...@git.apache.org>.
Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/69#issuecomment-94018951
Looks good, except that this breaks sqlline.py for Windows. Could you take a look at how psql.py uses the same approach but also uses subprocess.list2cmdline to allow running it on Windows, and try to use the same approach here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-1733: sqlline.py doesn't allow conne...
Posted by gabrielreid <gi...@git.apache.org>.
Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/69#issuecomment-94307344
This has been pushed to master and 4.x branch. Thanks @abisek!
@JamesRTaylor can you close this PR, or give me the required rights to do so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-1733: sqlline.py doesn't allow conne...
Posted by abisek <gi...@git.apache.org>.
Github user abisek commented on the pull request:
https://github.com/apache/phoenix/pull/69#issuecomment-94106504
Verified on Windows as well:
```
C:\Phoenix\phoenix\bin>python sqlline.py asreeniva-wsl2.internal.salesforce.com:2181:/hbase;TenantId=t1
Setting property: [isolation, TRANSACTION_READ_COMMITTED]
issuing: !connect jdbc:phoenix:asreeniva-wsl2.internal.salesforce.com:2181:/hbase;TenantId=t1 none none org.apache.phoenix.jdbc.PhoenixDriver
Connecting to jdbc:phoenix:asreeniva-wsl2.internal.salesforce.com:2181:/hbase;TenantId=t1
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request #69: PHOENIX-1733: sqlline.py doesn't allow connecting ...
Posted by abisek <gi...@git.apache.org>.
Github user abisek closed the pull request at:
https://github.com/apache/phoenix/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---