You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/06 19:58:20 UTC
[jira] [Commented] (CB-8722) Android should move icons to
res/mipmap-* rather than drawable
[ https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553012#comment-15553012 ]
ASF GitHub Bot commented on CB-8722:
------------------------------------
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-android/pull/340
CB-8722 - Move app icons from drawable to mipmap
https://issues.apache.org/jira/browse/CB-8722
Reasoning behind the change: https://androidbycode.wordpress.com/2015/02/14/goodbye-launcher-drawables-hello-mipmaps/
/cc @infil00p
This probably counts as a breaking change, so we might want to get this into 6.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-android mipmap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit 97855018e9aeb955f3dd7e31c91fb6b8f67e0c29
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-10-06T19:55:26Z
CB-8722 - Move icons from drawable to mipmap
----
> Android should move icons to res/mipmap-* rather than drawable
> --------------------------------------------------------------
>
> Key: CB-8722
> URL: https://issues.apache.org/jira/browse/CB-8722
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CordovaLib
> Reporter: Andrew Grieve
> Priority: Minor
>
> Refer to: http://developer.android.com/tools/projects/index.html#mipmap
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org