You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2008/05/21 14:59:55 UTC
[jira] Created: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
In ReduceTask::fetchOutputs, wait for result can be improved slightly
---------------------------------------------------------------------
Key: HADOOP-3427
URL: https://issues.apache.org/jira/browse/HADOOP-3427
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.18.0
The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Resolution: Fixed
Release Note: Improves the shuffle scheduler. It now waits for notifications from shuffle threads when it has scheduled enough, before scheduling more.
Status: Resolved (was: Patch Available)
I just committed this.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.3.patch, 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Open (was: Patch Available)
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Attachment: 3427.patch
This patch mainly introduces this change - Defines a number to indicate when the shuffle scheduler should stop and just wait for notifications from the fetchers. This number is hardcoded to (4 * numCopiers).
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Open (was: Patch Available)
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3427) In ReduceTask::fetchOutputs, wait
for result can be improved slightly
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602625#action_12602625 ]
Hadoop QA commented on HADOOP-3427:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383448/3427.3.patch
against trunk revision 663487.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2587/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2587/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2587/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2587/console
This message is automatically generated.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.3.patch, 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Attachment: 3427.patch
This fixes a comment in the earlier patch
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3427) In ReduceTask::fetchOutputs, wait
for result can be improved slightly
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602404#action_12602404 ]
Hadoop QA commented on HADOOP-3427:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382819/3427.patch
against trunk revision 663321.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2574/console
This message is automatically generated.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-3427:
------------------------------------
Release Note: Changed shuffle scheduler policy to wait for notifications from shuffle threads before scheduling more. (was: Improves the shuffle scheduler. It now waits for notifications from shuffle threads when it has scheduled enough, before scheduling more.)
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.3.patch, 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Patch Available (was: Open)
Retrying hudson
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Patch Available (was: Open)
Trying to run hudson again.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Open (was: Patch Available)
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Open (was: Patch Available)
Cancelling patch due to conflicts with trunk
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.3.patch, 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Attachment: 3427.patch
The last patch had an incorrect wait()
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Patch Available (was: Open)
Retrying hudson
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3427) In ReduceTask::fetchOutputs, wait
for result can be improved slightly
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602115#action_12602115 ]
Hadoop QA commented on HADOOP-3427:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382819/3427.patch
against trunk revision 662913.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2551/console
This message is automatically generated.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
queueing it for hudson. Forgot to thank Amareshwari for helping resolving the conflicts quickly.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.3.patch, 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Attachment: 3427.3.patch
This is updated w.r.t the trunk.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.3.patch, 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3427) In ReduceTask::fetchOutputs, wait
for result can be improved slightly
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601995#action_12601995 ]
Mahadev konar commented on HADOOP-3427:
---------------------------------------
+1 the patch looks good, though the fetchoutputs() needs refactoring urgently.
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for
result can be improved slightly
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3427:
--------------------------------
Status: Patch Available (was: Open)
> In ReduceTask::fetchOutputs, wait for result can be improved slightly
> ---------------------------------------------------------------------
>
> Key: HADOOP-3427
> URL: https://issues.apache.org/jira/browse/HADOOP-3427
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.18.0
>
> Attachments: 3427.patch, 3427.patch
>
>
> The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.