You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jean-Daniel Cryans <jd...@apache.org> on 2010/11/09 00:44:51 UTC
Review Request: HLog.findMemstoresWithEditsOlderThan needs to look for edits
that are equal to too
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
This patch simply adds the "<=" in findMemstoresWithEditsOlderThan, renames it to findMemstoresWithEditsEqualOrOlderThan, and fixes the unit tests.
This addresses bug HBASE-3208.
http://issues.apache.org/jira/browse/HBASE-3208
Diffs
-----
/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1032760
/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1032760
Diff: http://review.cloudera.org/r/1188/diff
Testing
-------
Thanks,
Jean-Daniel
Re: Review Request: HLog.findMemstoresWithEditsOlderThan needs to look for
edits that are equal to too
Posted by Jonathan Gray <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/#review1851
-----------------------------------------------------------
Ship it!
looks good to me
- Jonathan
On 2010-11-08 15:44:51, Jean-Daniel Cryans wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1188/
> -----------------------------------------------------------
>
> (Updated 2010-11-08 15:44:51)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> This patch simply adds the "<=" in findMemstoresWithEditsOlderThan, renames it to findMemstoresWithEditsEqualOrOlderThan, and fixes the unit tests.
>
>
> This addresses bug HBASE-3208.
> http://issues.apache.org/jira/browse/HBASE-3208
>
>
> Diffs
> -----
>
> /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1032760
> /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1032760
>
> Diff: http://review.cloudera.org/r/1188/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jean-Daniel
>
>