[GitHub] [maven-surefire] MartinKanters commented on a change in pull request #326: Fix message about forkCount parameter = 0

[GitBox <gi...@apache.org>]

MartinKanters commented on a change in pull request #326:
URL: https://github.com/apache/maven-surefire/pull/326#discussion_r536809495



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1142,8 +1142,8 @@ private void warnIfForkCountIsZero()
     {
         if ( "0".equals( getForkCount() ) )
         {
-            getConsoleLogger().warning( "The parameter forkCount should likely not be 0, not forking a JVM for tests "
-                + "reduce test accuracy, ensure to have a <forkCount> >= 1." );
+            getConsoleLogger().warning( "The parameter forkCount should likely not be 0. Not forking a JVM for tests "
+                + "reduces test accuracy. Ensure to have a <forkCount> >= 1." );

Review comment:
       Technically it is correct I think, but personally I would rewrite the middle sentence in the other way around. What do you think of: `Forking a JVM for tests improves test accuracy.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org