[GitHub] [pulsar] bharanic-dev commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

[GitBox <gi...@apache.org>]

bharanic-dev commented on a change in pull request #10657:
URL: https://github.com/apache/pulsar/pull/10657#discussion_r637135851



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java
##########
@@ -70,9 +70,10 @@
 
     // Default ctor: it is not expected that anything outside of this package will need to directly
     // construct a ResourceGroup (i.e., without going through ResourceGroupService).
-    protected ResourceGroup(ResourceGroupService rgs, ResourceGroupConfigInfo rgConfig) {
+    protected ResourceGroup(ResourceGroupService rgs, String name,
+                            org.apache.pulsar.common.policies.data.ResourceGroup rgConfig) {
         this.rgs = rgs;

Review comment:
       My understanding is this is the artifact of how the data is laid out in znode in zookeeper. The name of the resource-group is part of the path to znode. The data is the fields in the ResourceGroup datastructure. I think embedding the name in the data will likely be confusing and wasteful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org