You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/19 22:28:56 UTC

[GitHub] john-bodley commented on a change in pull request #5434: [security] add datasource sources

john-bodley commented on a change in pull request #5434: [security] add datasource sources
URL: https://github.com/apache/incubator-superset/pull/5434#discussion_r203890747
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -525,6 +525,10 @@ def link(self):
         name = escape(self.datasource_name)
         return Markup('<a href="{self.url}">{name}</a>').format(**locals())
 
+    @property
+    def datasource_sources(self):
+        return '{}.{}'.format(self.cluster_name, self.datasource_name)
 
 Review comment:
   This method should return a list. Also it seems wrong to encode the cluster name here as this is inconsistent with how the SQLA logic is defined. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org