You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/06/03 21:37:53 UTC

[Bug 55054] New: public method exitWhenFinished() removed from FileCleaningTracker.

https://issues.apache.org/bugzilla/show_bug.cgi?id=55054

            Bug ID: 55054
           Summary: public method exitWhenFinished() removed from
                    FileCleaningTracker.
           Product: Tomcat 7
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: jeffcoat@alumni.rice.edu

The March 15 commit "Update to Commons IO 2.4 and run UCDetector over the
copied classes" removed FileCleaningTracker.exitWhenFinished(), presumably by
accident.

This makes it difficult to stop the reaper thread, which leads to memory leaks.

http://svn.apache.org/viewvc?view=revision&revision=1456969

I believe this is an error (by the UCDetector?): Commons IO 2.4 does have this
method, and the FileCleaningTracker Javadocs still refer to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55054] public method exitWhenFinished() removed from FileCleaningTracker.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55054

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
(In reply to Mark Jeffcoat from comment #0)
> The March 15 commit "Update to Commons IO 2.4 and run UCDetector over the
> copied classes" removed FileCleaningTracker.exitWhenFinished(), presumably
> by accident.

It was deliberate, not accidental.

> This makes it difficult to stop the reaper thread, which leads to memory
> leaks.

There is no reaper thread. (More code that can be removed. Removal of unused
code is often an iterative process.)

> I believe this is an error (by the UCDetector?): Commons IO 2.4 does have
> this method, and the FileCleaningTracker Javadocs still refer to it.

As above, this was deliberate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org