[GitHub] [incubator-mxnet] DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions

[GitBox <gi...@apache.org>]

DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions
URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-512991874
 
 
   LGTM.
   
   @yuxihu Thanks for stepping in quickly to provide this fix.  I would appreciate any additional insight you have that might help me from introducing this sort of problem in the future.  For example, I see that the wildcard pattern you introduced to ./make/config/libmxnet.{sym,ver} matches the missing entrypoints:
   ```
   $ nm libmxnet.so | grep LibCheck | grep " T "
   0000000003c889d0 T _ZN5mxnet7Context13CudaLibChecksEv
   0000000003c89730 T _ZN5mxnet7Context14CuDNNLibChecksEv
   ```
   However, I can also perform:
   ```
   $ nm libmxnet.so | grep ResourceManager | grep Get | grep " T "
   0000000003c77c00 T _ZN5mxnet15ResourceManager3GetEv
   ```
   Why is no wildcard pattern similarly needed to cover ResourceManager::Get(), as created in ./include/mxnet/resource.h and ./src/resource.cc?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services