[jira] [Commented] (MAPREDUCE-2548) Log improvements in DBOutputFormat.java and CounterGroup.java

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042878#comment-13042878 ] 

Hadoop QA commented on MAPREDUCE-2548:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481234/MAPREDUCE-2548.patch
  against trunk revision 1130554.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI
                  org.apache.hadoop.mapred.TestDebugScript

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/334//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/334//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/334//console

This message is automatically generated.

> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-2548
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged. 
> {code:title=DBOutputFormat.java|borderStyle=solid}
>     
> public void write(K key, V value) throws IOException {
>       try {
>         key.write(statement);
>         statement.addBatch();
>       } catch (SQLException e) {
>         e.printStackTrace();
>       }
>     }
> {code}
> 2. Missing resource information can be logged. 
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
>     this.name = name;
>     try {
>       bundle = getResourceBundle(name);
>     }
>     catch (MissingResourceException neverMind) {
>     }
>     displayName = localize("CounterGroupName", name);
>   }
>   private String localize(String key, String defaultValue) {
>     String result = defaultValue;
>     if (bundle != null) {
>       try {
>         result = bundle.getString(key);
>       }
>       catch (MissingResourceException mre) {
>       }
>     }
>     return result;
>   }
> {code}
>     

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira