Re: [PR] [SPARK-46003][UI][TESTS] Create an ui-test module with Jest to test ui javascript code [spark]

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1467245519


##########
core/src/main/resources/org/apache/spark/ui/static/log-view.js:
##########
@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-/* global $, getBaseURI */
+/* global $ */
+
+import {getBaseURI} from "./utils.js";

Review Comment:
   It seems that we need to recover this. Could you review this, @yaooqinn ?
   - https://github.com/apache/spark/pull/44896



##########
core/src/main/resources/org/apache/spark/ui/static/log-view.js:
##########
@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
-/* global $, getBaseURI */
+/* global $ */
+
+import {getBaseURI} from "./utils.js";

Review Comment:
   It seems that we need to recover `log-view.js`. Could you review this, @yaooqinn ?
   - https://github.com/apache/spark/pull/44896



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org