[GitHub] [couchdb-documentation] kocolosk commented on a change in pull request #410: add rfc for map indexes

[GitBox <gi...@apache.org>]

kocolosk commented on a change in pull request #410: add rfc for map indexes
URL: https://github.com/apache/couchdb-documentation/pull/410#discussion_r340346506
 
 

 ##########
 File path: rfcs/008-map-indexes.md
 ##########
 @@ -62,15 +62,17 @@ The data model for a map indexed is:
 
 ```
 (<database>, ?DB_VIEWS, <view_signature>, ?VIEW_UPDATE_SEQ) = Sequence
-(<database>, ?DB_VIEWS, <view_signature>, ?VIEW_ID_RANGE, <_id>, <view_id>) = [emitted keys]
+{<database>, ?DB_VIEWS, <view_signature>, ?VIEW_ID_INFO, view_id, ?VIEW_ROW_COUNT} = <row_count>
+{<database>, ?DB_VIEWS, <view_signature>, ?VIEW_ID_INFO, view_id, ?VIEW_KV_SIZE} = <kv_size>
+(<database>, ?DB_VIEWS, <view_signature>, ?VIEW_ID_RANGE, <_id>, <view_id>) = [total_keys, total_size, unique_keys]
 (<database>, ?DB_VIEWS, <view_signature>, ?VIEW_MAP_RANGE, <view_id>, <key>, <_id>, ?ROW_KEYS <count>) = <emitted_keys>
-(<database>, ?DB_VIEWS, <view_signature>, ?VIEW_MAP_RANGE, <view_id>, <key>, <_id>, ?ROW_VALUE, <count>) = <emitted_value>
+(<database>, ?DB_VIEWS, <view_signature>, ?VIEW_MAP_RANGE, <view_id>, {<key>, <_id>}, <count>, ?ROW_VALUE) = <emitted_value>
 
 Review comment:
   OK. I don't think that's worth doubling the overhead.
   
   I'd like to leave a buffer so that we've got options for things like storing Values in an encrypted form. We also need a buffer on the key for several reasons:
   
   - sort key generation
   - database name (are we really using the raw database name here?)
   - view signature
   
   Agreed that it would be bad if views silently crash and omit rows -- at the risk of scope creep do we need to include in the data model the list of documents that failed to index that we had discussed in the past?
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services