You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@atlas.apache.org by sa...@apache.org on 2018/01/16 21:39:11 UTC
atlas git commit: ATLAS-2059: Update test-patch.sh script to fix
incorrect exit code
Repository: atlas
Updated Branches:
refs/heads/master 3689a3582 -> 72030ad1b
ATLAS-2059: Update test-patch.sh script to fix incorrect exit code
Project: http://git-wip-us.apache.org/repos/asf/atlas/repo
Commit: http://git-wip-us.apache.org/repos/asf/atlas/commit/72030ad1
Tree: http://git-wip-us.apache.org/repos/asf/atlas/tree/72030ad1
Diff: http://git-wip-us.apache.org/repos/asf/atlas/diff/72030ad1
Branch: refs/heads/master
Commit: 72030ad1bde9e7d00084e9811b6a2051068e0ed2
Parents: 3689a35
Author: Sarath Subramanian <ss...@hortonworks.com>
Authored: Tue Jan 16 13:38:42 2018 -0800
Committer: Sarath Subramanian <ss...@hortonworks.com>
Committed: Tue Jan 16 13:38:58 2018 -0800
----------------------------------------------------------------------
dev-support/test-patch.sh | 36 ++++++------------------------------
1 file changed, 6 insertions(+), 30 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/atlas/blob/72030ad1/dev-support/test-patch.sh
----------------------------------------------------------------------
diff --git a/dev-support/test-patch.sh b/dev-support/test-patch.sh
index e9fa610..00df3ef 100755
--- a/dev-support/test-patch.sh
+++ b/dev-support/test-patch.sh
@@ -832,6 +832,7 @@ if [[ $JENKINS == "true" ]] ; then
exit 100
fi
fi
+
downloadPatch
verifyPatch
(( RESULT = RESULT + $? ))
@@ -839,20 +840,14 @@ if [[ $RESULT != 0 ]] ; then
submitJiraComment 1
cleanupAndExit 1
fi
-#prebuildWithoutPatch
-(( RESULT = RESULT + $? ))
-if [[ $RESULT != 0 ]] ; then
- submitJiraComment 1
- cleanupAndExit 1
-fi
+
checkAuthor
(( RESULT = RESULT + $? ))
if [[ $JENKINS == "true" ]] ; then
cleanUpXml
fi
-#checkTests
-(( RESULT = RESULT + $? ))
+
applyPatch
APPLY_PATCH_RET=$?
(( RESULT = RESULT + $APPLY_PATCH_RET ))
@@ -860,30 +855,11 @@ if [[ $APPLY_PATCH_RET != 0 ]] ; then
submitJiraComment 1
cleanupAndExit 1
fi
-#checkJavacWarnings
-JAVAC_RET=$?
-#2 is returned if the code could not compile
-if [[ $JAVAC_RET == 2 ]] ; then
- submitJiraComment 1
- cleanupAndExit 1
-fi
-(( RESULT = RESULT + $JAVAC_RET ))
-#checkJavadocWarnings
-(( RESULT = RESULT + $? ))
-#checkStyle
-(( RESULT = RESULT + $? ))
-#checkFindbugsWarnings
-(( RESULT = RESULT + $? ))
-#checkReleaseAuditWarnings
-(( RESULT = RESULT + $? ))
+
buildAndInstall
-### Run tests for Jenkins or if explictly asked for by a developer
-if [[ $JENKINS == "true" || $RUN_TESTS == "true" ]] ; then
- #runTests
- (( RESULT = RESULT + $? ))
-fi
+
JIRA_COMMENT_FOOTER="Test results: $BUILD_URL/testReport/
$JIRA_COMMENT_FOOTER"
submitJiraComment $RESULT
-cleanupAndExit $RESULT
+cleanupAndExit $RESULT
\ No newline at end of file