You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by st...@apache.org on 2015/03/11 01:21:35 UTC

cordova-coho git commit: plugins releases now use npm pack instead of creating a zip

Repository: cordova-coho
Updated Branches:
  refs/heads/master dcaaa3282 -> 4489e4613


plugins releases now use npm pack instead of creating a zip


Project: http://git-wip-us.apache.org/repos/asf/cordova-coho/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-coho/commit/4489e461
Tree: http://git-wip-us.apache.org/repos/asf/cordova-coho/tree/4489e461
Diff: http://git-wip-us.apache.org/repos/asf/cordova-coho/diff/4489e461

Branch: refs/heads/master
Commit: 4489e4613ca541fe86ce86f49942b247a4e02e8b
Parents: dcaaa32
Author: Steve Gill <st...@gmail.com>
Authored: Tue Mar 10 17:21:32 2015 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Tue Mar 10 17:21:32 2015 -0700

----------------------------------------------------------------------
 docs/plugins-release-process.md | 5 ++---
 src/create-verify-archive.js    | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/4489e461/docs/plugins-release-process.md
----------------------------------------------------------------------
diff --git a/docs/plugins-release-process.md b/docs/plugins-release-process.md
index 64a3f31..3023ec2 100644
--- a/docs/plugins-release-process.md
+++ b/docs/plugins-release-process.md
@@ -143,18 +143,17 @@ Ensure you have the svn repos checked out:
 
 Create archives from your tags:
 
-    TODO: As soon as plugins have package.json files checked in update coho to use "npm pack", and then delete this TODO.
     coho create-archive -r ${ACTIVE// / -r } --dest cordova-dist-dev/$JIRA
 
 Sanity Check:
 
     # Manually double check version numbers are correct on the file names
     # Then run:
-    coho verify-archive cordova-dist-dev/$JIRA/*.zip
+    coho verify-archive cordova-dist-dev/$JIRA/*.tgz
 
 Upload:
 
-    cd cordova-dist-dev && svn up && svn add $JIRA && svn commit -m "$JIRA Uploading release candidates for plugins release"
+    (cd cordova-dist-dev && svn up && svn add $JIRA && svn commit -m "$JIRA Uploading release candidates for plugins release")
 
 * Find your release here: https://dist.apache.org/repos/dist/dev/cordova/
 

http://git-wip-us.apache.org/repos/asf/cordova-coho/blob/4489e461/src/create-verify-archive.js
----------------------------------------------------------------------
diff --git a/src/create-verify-archive.js b/src/create-verify-archive.js
index 5406a43..eafbeb7 100644
--- a/src/create-verify-archive.js
+++ b/src/create-verify-archive.js
@@ -82,7 +82,7 @@ exports.createCommand = function*(argv) {
         yield gitutil.gitCheckout(tag);
         print('Creating archive of ' + repo.repoName + '@' + tag);
 
-        if (!(repo.id==='mobile-spec' || repo.id.indexOf('plugin-')==0)) {
+        if (!(repo.id==='mobile-spec')) {
             if (!argv['allow-pending'] && (yield gitutil.pendingChangesExist())) {
                 apputil.fatal('Aborting because pending changes exist in ' + repo.repoName);
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org