You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/27 15:29:53 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
dawidwys commented on a change in pull request #13073:
URL: https://github.com/apache/flink/pull/13073#discussion_r512786339
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -163,6 +164,7 @@ public void sendSourceEventToCoordinator(SourceEvent event) {
@Override
public void close() throws Exception {
eventTimeLogic.stopPeriodicWatermarkEmits();
+ currentMainOutput.emitWatermark(Watermark.MAX_WATERMARK);
Review comment:
Unfortunately that will not work in the `BATCH` mode we will introduce shortly. In `BATCH` mode the `currentMainOutput` will ignore all watermarks. At the same time we should still emit `MAX_WATERMARK` in the `BATCH` mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org