You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "enapps-enorman (via GitHub)" <gi...@apache.org> on 2023/05/06 22:48:18 UTC
[GitHub] [sling-org-apache-sling-testing-jcr-mock] enapps-enorman opened a new pull request, #19: SLING-11863 getAncestor interprets the depth argument incorrectly
enapps-enorman opened a new pull request, #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/19
The [javadocs](https://javadoc.io/static/javax.jcr/jcr/2.0/javax/jcr/Item.html#getAncestor(int)) for "Item javax.jcr.Item.getAncestor(int depth)" describes the depth argument as:
```
depth = 0 returns the root node of a workspace.
depth = 1 returns the child of the root node along the path to this Item.
depth = 2 returns the grandchild of the root node along the path to this Item.
And so on to depth = n, where n is the depth of this Item, which returns this Item itself.
```
However, the org.apache.sling.testing.mock.jcr.AbstractItem#getAncestor implementation is using "ResourceUtil.getParent(getPath(), depth)" which interprets the second argument as:
```
level = 0 returns the path.
level = 1 returns the parent of path, if it exists, null otherwise.
level = 2 returns the grandparent of path, if it exists, null otherwise.
```
Expected:
AbstractItem#getAncestor should resolve the ancestor path as the item depth minus the supplied depth argument.
```
this.session.getItem(ResourceUtil.getParent(getPath(), getDepth() - depth));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] enapps-enorman merged pull request #19: SLING-11863 getAncestor interprets the depth argument incorrectly
Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman merged PR #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #19: SLING-11863 getAncestor interprets the depth argument incorrectly
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #19:
URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/19#issuecomment-1537237684
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=19&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org