You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/09/19 14:54:42 UTC
[GitHub] [couchdb-fauxton] Antonio-Maranhao opened a new pull request, #1366: Replace brace with react-ace
Antonio-Maranhao opened a new pull request, #1366:
URL: https://github.com/apache/couchdb-fauxton/pull/1366
## Overview
Replaces the `brace` dependency, which hasn't received any updates for 5+ years, with `react-ace` which works with the most recent releases of the ACE Editor. The work was based on https://github.com/apache/couchdb-fauxton/pull/1331 which had to be reverted due to issues with the release build. Both the dev server and release builds are fully functional.
Also takes advantage of the new `useStrictCSP` option in the ACE Editor so allow Fauxton to work without the `style-src: 'unsafe-inline'` Content-Security Policy.
## Testing recommendations
When editing JSON documents:
- Syntax highlighting is working
- Editor shows syntax errors - e.g. remove a comma between fields and the red X icon should be displayed on the editor gutter
- String editor:
- position the cursor inside a string value then click the "String Editor" icon displayed on the editor gutter
- In the String Editor, modify the string value then click "Modify text" button.
- Verify the string value is updated
When editing a Mango Query:
- Syntax highlighting is working
- Editor shows syntax errors
- Click the "Enter zen mode" icon on the top right of the editor to enter the full-screen editor
- Click the "Switch zen theme" icon on the right to verify it switches between the light / dark themes
## GitHub issue number
n/a
## Related Pull Requests
n/a
## Checklist
- [x] Code is written and works correctly;
- [ ] Changes are covered by tests;
- [ ] Documentation reflects the changes;
- [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/main/rebar.config.script) with the correct tag once a new Fauxton release is made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] fryjordan commented on pull request #1366: Replace brace with react-ace
Posted by GitBox <gi...@apache.org>.
fryjordan commented on PR #1366:
URL: https://github.com/apache/couchdb-fauxton/pull/1366#issuecomment-1252166233
Have run through the testing recommendations, and looked over the code. LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] Antonio-Maranhao merged pull request #1366: Replace brace with react-ace
Posted by GitBox <gi...@apache.org>.
Antonio-Maranhao merged PR #1366:
URL: https://github.com/apache/couchdb-fauxton/pull/1366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org