You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/08/23 13:38:53 UTC
[GitHub] [systemds] Shafaq-Siddiqi opened a new pull request #1034: [SYSTEMDS-2633] Builtin "dml_map()" will execute the given Java code …
Shafaq-Siddiqi opened a new pull request #1034:
URL: https://github.com/apache/systemds/pull/1034
…on a Frame.
The built-in use the Janino compiler for run-time code generation and compilation and accepts a frame and string (containing Java code) as input and execute the code in string on frame and returns the output frame.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1034: [SYSTEMDS-2633] Builtin "dml_map()" will execute the given Java code …
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1034:
URL: https://github.com/apache/systemds/pull/1034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1034: [SYSTEMDS-2633] Builtin "dml_map()" will execute the given Java code …
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1034:
URL: https://github.com/apache/systemds/pull/1034#issuecomment-679250773
LGTM - thanks for this great addition. I made some moderate changes though: (1) support for real lambda expressions with arbitrary bound variables, (2) support for multi-column frames, (3) renamed from dmlMap to map, (4) added the binary.frame test package to our github tests, (5) generated subsclasses of FrameMapFunction to avoid java reflection for performance, and (6) some minor formatting changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org