[GitHub] mistercrunch commented on a change in pull request #4702: RFC: add logger that logs into browser console

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4702: RFC: add logger that logs into browser console
URL: https://github.com/apache/incubator-superset/pull/4702#discussion_r178688346
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -745,8 +745,10 @@ def shortner(self):
         obj = models.Url(url=url)
         db.session.add(obj)
         db.session.commit()
-        return('http://{request.headers[Host]}/{directory}?r={obj.id}'.format(
-            request=request, directory=directory, obj=obj))
+        return Response(
 
 Review comment:
   Curious on the angle here, you prefer an explicit `Response` object?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services