You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lucliu1108 (via GitHub)" <gi...@apache.org> on 2026/07/30 20:28:26 UTC
[PR] [DO NOT MERGE]KAFKA-20867: Upgrade RocksDB dependency from 10.1.3 to 10.10.1 [kafka]
lucliu1108 opened a new pull request, #22998:
URL: https://github.com/apache/kafka/pull/22998
## Summary
After AK 4.4 code freeze, we should upgrade RocksDB version to a newer one, test its stability and make it to the next major release.
ticket: https://issues.apache.org/jira/browse/KAFKA-20867
## Major change
Then major API change affecting RocksDBSetter interface is `Options#maxWriteBufferNumberToMaintain` removed (its corresponding setter as well). Therefore, in `RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java`, the corresponding getter and setting will be marked as deprecated since 4.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20867: Upgrade RocksDB dependency from 10.1.3 to 10.10.1 [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22998:
URL: https://github.com/apache/kafka/pull/22998#issuecomment-5500085725
merged #22998 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20867: Upgrade RocksDB dependency from 10.1.3 to 10.10.1 [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #22998:
URL: https://github.com/apache/kafka/pull/22998#issuecomment-5495747860
I ran an extra forward on-disk compatibility check beyond the in-version suite, since this bump touches persistent state: generated a Streams RocksDBStore with the old RocksDB (10.1.3) — three key-values plus two KIP-1035 committed changelog offsets, flushed to SSTs — then reopened that exact directory under 10.10.1 and asserted the reads survive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE]KAFKA-20867: Upgrade RocksDB dependency from 10.1.3 to 10.10.1 [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22998:
URL: https://github.com/apache/kafka/pull/22998#issuecomment-5212211355
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20867: Upgrade RocksDB dependency from 10.1.3 to 10.10.1 [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck merged PR #22998:
URL: https://github.com/apache/kafka/pull/22998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20867: Upgrade RocksDB dependency from 10.1.3 to 10.10.1 [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #22998:
URL: https://github.com/apache/kafka/pull/22998#discussion_r3905380935
##########
docs/streams/upgrade-guide.md:
##########
@@ -65,6 +65,10 @@ Starting in Kafka Streams 2.6.x, a new processing mode is available, named EOS v
Since 2.6.0 release, Kafka Streams depends on a RocksDB version that requires MacOS 10.14 or higher.
+## Streams API changes in 4.5.0
+
+Upgraded RocksDB dependency to version 10.10.1(from 10.1.3). This upgrade removes an API: `Options#setMaxWriteBufferNumberToMaintain` and `Options#maxWriteBufferNumberToMaintain` have been removed, as `max_write_buffer_number_to_maintain` was deleted from RocksDB's `ColumnFamilyOptions` in version 10.5.0. This change is primarily relevant to users implementing custom RocksDB configurations via `rocksdb.config.setter`. Users relying on `max_write_buffer_number_to_maintain` will need to remove that configuration. Consult the [RocksDB changelog](https://github.com/facebook/rocksdb/blob/main/HISTORY.md) between 10.1.3 and 10.10.1 for other changes.
Review Comment:
Can we add a sentence stating `maxWriteBufferNumberToMaintain` will now return `0` due to the deprecation and should not be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org