You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/20 12:27:50 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #812: infocard: Adding support to redirect to publicip
davidjumani opened a new pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812
Adding support to redirect to publicip. Works with cks clusters after https://github.com/apache/cloudstack/pull/4414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#issuecomment-712816558
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#discussion_r508669557
##########
File path: src/components/view/InfoCard.vue
##########
@@ -308,7 +308,8 @@
type="environment"
@click="$message.success(`${$t('label.copied.clipboard')} : ${ ipaddress }`)"
v-clipboard:copy="ipaddress" />
- <span>{{ ipaddress }}</span>
+ <router-link v-if="resource.ipaddressid" :to="{ path: '/publicip/' + resource.ipaddressid }">{{ ipaddress }}</router-link>
Review comment:
Don't think that'll be needed since only public IPs will have an id associated with it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#issuecomment-717817388
I checked few views where this lgtm, but it could add regression for few possible places if ipaddress is not returned just ipadddressid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#discussion_r508584864
##########
File path: src/components/view/InfoCard.vue
##########
@@ -308,7 +308,8 @@
type="environment"
@click="$message.success(`${$t('label.copied.clipboard')} : ${ ipaddress }`)"
v-clipboard:copy="ipaddress" />
- <span>{{ ipaddress }}</span>
+ <router-link v-if="resource.ipaddressid" :to="{ path: '/publicip/' + resource.ipaddressid }">{{ ipaddress }}</router-link>
Review comment:
We need to check if ip address is always public IP address?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#issuecomment-712832936
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/812 (JID-3603)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#issuecomment-712816008
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #812: infocard: Adding support to redirect to publicip
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#discussion_r513177753
##########
File path: src/components/view/InfoCard.vue
##########
@@ -308,7 +308,8 @@
type="environment"
@click="$message.success(`${$t('label.copied.clipboard')} : ${ ipaddress }`)"
v-clipboard:copy="ipaddress" />
- <span>{{ ipaddress }}</span>
+ <router-link v-if="resource.ipaddressid" :to="{ path: '/publicip/' + resource.ipaddressid }">{{ ipaddress }}</router-link>
Review comment:
I'll need to do some checks before merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org