You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Mark Struberg (JIRA)" <ji...@apache.org> on 2012/06/13 18:06:49 UTC

[jira] [Created] (DELTASPIKE-196) review ConfigProperty and Converter logic

Mark Struberg created DELTASPIKE-196:
----------------------------------------

             Summary: review ConfigProperty and Converter logic
                 Key: DELTASPIKE-196
                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-196
             Project: DeltaSpike
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.3-incubating
            Reporter: Mark Struberg
            Assignee: Mark Struberg
             Fix For: 0.3-incubating


Our current @ConfigProperty implementation is based on complex and expensive ProcessInjectionTarget handling. It also uses the @Qualifier annotation, but in fact it isn't a Qualifier!

We can implement all the original requirements with simple producer methods. 

There is also no need for all the Converter stuff as CDI allows a user to simply provide his own Qualifier and producer methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (DELTASPIKE-196) review ConfigProperty and Converter logic

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DELTASPIKE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg reopened DELTASPIKE-196:
--------------------------------------


we still have the eager() flag in the @ConfigProperty.

As it is not possible to perform this check for user defined configurations we should opt for removing it. 
                
> review ConfigProperty and Converter logic
> -----------------------------------------
>
>                 Key: DELTASPIKE-196
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-196
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.3-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 0.3-incubating
>
>
> Our current @ConfigProperty implementation is based on complex and expensive ProcessInjectionTarget handling. It also uses the @Qualifier annotation, but in fact it isn't a Qualifier!
> We can implement all the original requirements with simple producer methods. 
> There is also no need for all the Converter stuff as CDI allows a user to simply provide his own Qualifier and producer methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DELTASPIKE-196) review ConfigProperty and Converter logic

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DELTASPIKE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved DELTASPIKE-196.
--------------------------------------

    Resolution: Fixed
    
> review ConfigProperty and Converter logic
> -----------------------------------------
>
>                 Key: DELTASPIKE-196
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-196
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.3-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 0.3-incubating
>
>
> Our current @ConfigProperty implementation is based on complex and expensive ProcessInjectionTarget handling. It also uses the @Qualifier annotation, but in fact it isn't a Qualifier!
> We can implement all the original requirements with simple producer methods. 
> There is also no need for all the Converter stuff as CDI allows a user to simply provide his own Qualifier and producer methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DELTASPIKE-196) review ConfigProperty and Converter logic

Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DELTASPIKE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg resolved DELTASPIKE-196.
--------------------------------------

    Resolution: Fixed
    
> review ConfigProperty and Converter logic
> -----------------------------------------
>
>                 Key: DELTASPIKE-196
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-196
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.3-incubating
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 0.3-incubating
>
>
> Our current @ConfigProperty implementation is based on complex and expensive ProcessInjectionTarget handling. It also uses the @Qualifier annotation, but in fact it isn't a Qualifier!
> We can implement all the original requirements with simple producer methods. 
> There is also no need for all the Converter stuff as CDI allows a user to simply provide his own Qualifier and producer methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira