[jira] [Resolved] (CALCITE-4422) Add MethodCanBeStatic check via ErrorProne

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov resolved CALCITE-4422.
----------------------------------------
    Fix Version/s: 1.27.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/404f968f6079360621896e6ee20ec12488a40bc2

> Add MethodCanBeStatic check via ErrorProne
> ------------------------------------------
>
>                 Key: CALCITE-4422
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4422
>             Project: Calcite
>          Issue Type: Improvement
>    Affects Versions: 1.26.0
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> See https://errorprone.info/bugpattern/MethodCanBeStatic
> {quote}A private method that does not reference the enclosing instance can be static{quote}
> Note: the key driver is code readability. If a method is static, it is clear that it can't access instance fields, and all it can access is provided via arguments.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)