[GitHub] [incubator-pinot] apucher commented on pull request #6613: [WIP] Basic auth controller

[GitBox <gi...@apache.org>]

apucher commented on pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#issuecomment-793185590


   > Thanks so much for this PR. As part of this can we also add a new API to enable credential verification ? (eg: from the Cluster Manager UI). I'm thinking of something like this: "http://controller-host:port/verifyauth" where you pass in the token and verify whether its correct.
   > 
   > The other option is to annotate one of the existing APIs eg: GET /tables with "Authenticate" and reuse that. However, a new API might be cleaner. What do you think ?
   
   added `/auth/info` and `/auth/verify` endpoints.
   **info** provides a workflow name to be supported from the web UI, including `NONE`, `BASIC`, and `OAUTH2`
   **verify** allows to verify access to API endpoints in a generic fashion, or simply to sanity-check auth headers without additional query params


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org