(kvrocks) branch unstable updated: chore(config): align max-backup-keep-hours in kvrocks.conf with config.cc default (#3717)

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aleksraiden pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 1139e0624 chore(config): align max-backup-keep-hours in kvrocks.conf with config.cc default (#3717)
1139e0624 is described below

commit 1139e0624ff72e88ba22b4c45ef98a8cbf203501
Author: Muskan Gulia <mu...@gmail.com>
AuthorDate: Tue Oct 27 12:14:35 2026 +0530

    chore(config): align max-backup-keep-hours in kvrocks.conf with config.cc default (#3717)
    
    ## Summary
    
    - Align `max-backup-keep-hours` in `kvrocks.conf` with the C++ default
    of `0`.
    - `rocksdb.block_cache_size` is intentionally left at `4096` in
    `kvrocks.conf`, per maintainer feedback.
    - `compaction-checker-cron` and `rocksdb.compression` are left unchanged
    and will be handled in a follow-up once the direction is decided.
    
    Note: this is a behavior change for users who load `kvrocks.conf`
    (including the Docker image). Their backups will no longer be purged for
    being older than 24 hours. Users who don't load the file already get
    `0`. Count-based, replacement, full-sync and `FLUSHBACKUP` cleanup are
    unchanged.
    
       Refs #1665
    
       ## Testing
    
       - `git diff --check`
       - No build or test run (configuration-value and comment-only change)
    
       ## AI use
    
    Codex helped compare the configuration defaults and trace the backup
    purge logic. I independently verified the resulting diff and the key
    source lines.
    
    ---------
    
    Co-authored-by: Aleks Lozovyuk <al...@gmail.com>
---
 kvrocks.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kvrocks.conf b/kvrocks.conf
index 0337b6ab1..88ef8b44f 100644
--- a/kvrocks.conf
+++ b/kvrocks.conf
@@ -442,8 +442,8 @@ max-db-size 0
 max-backup-to-keep 1
 
 # The maximum hours to keep the backup. If max-backup-keep-hours is 0, wouldn't purge any backup.
-# default: 1 day
-max-backup-keep-hours 24
+# Default: 0 (i.e. no age-based purge)
+max-backup-keep-hours 0
 
 # max-bitmap-to-string-mb use to limit the max size of bitmap to string transformation(MB).
 #