You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <pl...@linkedin.com> on 2010/09/10 13:03:03 UTC
Cleaning up javascript with Closure Linter
A while back I had started cleaning up the javascript code base to use
improved JsDoc annotations.
Recently the Closure Linter was released:
http://code.google.com/closure/utilities/
I'd like to propose that we run all of the javascript code through
fixjsstyle. A patch of this size causes codereview to fail. If you're
curious to see what types of changes are made you can see the diff here:
http://www.inuus.com/tmp/linter.diff
--
Paul Lindner -- plindner@linkedin.com -- linkedin.com/in/plindner
Re: Cleaning up javascript with Closure Linter
Posted by Pablo Graña <pa...@globant.com>.
There is also jslint, that can be run from a maven plugin. It does not
modifies the code, just reports on practicese, as checkstyle or findbugs.
On Fri, Sep 10, 2010 at 8:03 AM, Paul Lindner <pl...@linkedin.com> wrote:
> A while back I had started cleaning up the javascript code base to use
> improved JsDoc annotations.
>
> Recently the Closure Linter was released:
>
> http://code.google.com/closure/utilities/
>
> I'd like to propose that we run all of the javascript code through
> fixjsstyle. A patch of this size causes codereview to fail. If you're
> curious to see what types of changes are made you can see the diff here:
> http://www.inuus.com/tmp/linter.diff
>
> --
> Paul Lindner -- plindner@linkedin.com -- linkedin.com/in/plindner
>
--
Pablo Gra\~na
Chief Architect
Globant
Arg Office: +54 (11) 4109 1743
UK Office: +44 (20) 7043 8269 int 8043
US Office: +1 (212) 400 7686 int 8043
Re: Cleaning up javascript with Closure Linter
Posted by Paul Lindner <pl...@linkedin.com>.
Okay, big cleanup patch landed. If you need to merge your patch you might
want to run things through fixjsstyle script to harmonize.
On Fri, Sep 10, 2010 at 5:10 AM, Gagandeep Singh <ga...@google.com>wrote:
> The patch looks good. A script to split all the files into multiple
> codereviews could be helpful here.
>
> Thanks
> Gagan
>
>
>
>
> On Fri, Sep 10, 2010 at 4:33 PM, Paul Lindner <pl...@linkedin.com>
> wrote:
>
> > A while back I had started cleaning up the javascript code base to use
> > improved JsDoc annotations.
> >
> > Recently the Closure Linter was released:
> >
> > http://code.google.com/closure/utilities/
> >
> > I'd like to propose that we run all of the javascript code through
> > fixjsstyle. A patch of this size causes codereview to fail. If you're
> > curious to see what types of changes are made you can see the diff here:
> > http://www.inuus.com/tmp/linter.diff
> >
> > --
> > Paul Lindner -- plindner@linkedin.com -- linkedin.com/in/plindner
> >
>
--
Paul Lindner -- plindner@linkedin.com -- linkedin.com/in/plindner
Re: Cleaning up javascript with Closure Linter
Posted by Gagandeep Singh <ga...@google.com>.
The patch looks good. A script to split all the files into multiple
codereviews could be helpful here.
Thanks
Gagan
On Fri, Sep 10, 2010 at 4:33 PM, Paul Lindner <pl...@linkedin.com> wrote:
> A while back I had started cleaning up the javascript code base to use
> improved JsDoc annotations.
>
> Recently the Closure Linter was released:
>
> http://code.google.com/closure/utilities/
>
> I'd like to propose that we run all of the javascript code through
> fixjsstyle. A patch of this size causes codereview to fail. If you're
> curious to see what types of changes are made you can see the diff here:
> http://www.inuus.com/tmp/linter.diff
>
> --
> Paul Lindner -- plindner@linkedin.com -- linkedin.com/in/plindner
>