You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@twitter.com> on 2014/09/05 00:54:38 UTC

Review Request 25361: Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25361/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-688
    https://issues.apache.org/jira/browse/AURORA-688


Repository: aurora


Description
-------

Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.


Diffs
-----

  docs/vagrant.md b66ff67973c2a7893230aac6164b368e8bccd596 
  examples/vagrant/aurorabuild.sh 8b39a167e23ad2569c57dd0eb29ef6025c1b7fad 
  examples/vagrant/provision-dev-cluster.sh 4883df244a157371b4046b394bdf77f03e2e2470 

Diff: https://reviews.apache.org/r/25361/diff/


Testing
-------

vagrant destroy && vagrant up && bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Joshua Cohen


Re: Review Request 25361: Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.

Posted by Bill Farner <wf...@apache.org>.

> On Sept. 5, 2014, 9:40 p.m., Bill Farner wrote:
> > Ship It!

This is now on master
```
commit 599a7dc
Author: Joshua Cohen <jc...@twitter.com>
Date:   Fri Sep 5 14:40:46 2014 -0700

    Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build
    commands in the vagrant image.
    
    Bugs closed: AURORA-688
    
    Reviewed at https://reviews.apache.org/r/25361/
```


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25361/#review52512
-----------------------------------------------------------


On Sept. 4, 2014, 10:54 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25361/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 10:54 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-688
>     https://issues.apache.org/jira/browse/AURORA-688
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.
> 
> 
> Diffs
> -----
> 
>   docs/vagrant.md b66ff67973c2a7893230aac6164b368e8bccd596 
>   examples/vagrant/aurorabuild.sh 8b39a167e23ad2569c57dd0eb29ef6025c1b7fad 
>   examples/vagrant/provision-dev-cluster.sh 4883df244a157371b4046b394bdf77f03e2e2470 
> 
> Diff: https://reviews.apache.org/r/25361/diff/
> 
> 
> Testing
> -------
> 
> vagrant destroy && vagrant up && bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Re: Review Request 25361: Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25361/#review52512
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Sept. 4, 2014, 10:54 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25361/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 10:54 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-688
>     https://issues.apache.org/jira/browse/AURORA-688
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update vagrant provisioning and aurorabuild scripts to remove the need to sudo to run build commands in the vagrant image.
> 
> 
> Diffs
> -----
> 
>   docs/vagrant.md b66ff67973c2a7893230aac6164b368e8bccd596 
>   examples/vagrant/aurorabuild.sh 8b39a167e23ad2569c57dd0eb29ef6025c1b7fad 
>   examples/vagrant/provision-dev-cluster.sh 4883df244a157371b4046b394bdf77f03e2e2470 
> 
> Diff: https://reviews.apache.org/r/25361/diff/
> 
> 
> Testing
> -------
> 
> vagrant destroy && vagrant up && bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>