You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Zixuan Liu <no...@gmail.com> on 2023/09/05 09:09:25 UTC
[DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Hi Pulsar Community,
Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
Thanks,
Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by Zixuan Liu <no...@gmail.com>.
Hi all,
Thank you for your feedback. Let's support this feature first!
Thanks,
Zixuan
Xiangying Meng <xi...@apache.org> 于2023年9月26日周二 09:39写道：
>
> Hi Zixuan,
>
> This is really a great feature. I support it.
>
> Regarding cherry-pick, as far as I know, we have cherry-picked some
> configuration items and interfaces into branch-2.10.
> But that should be mentioned in a separate discussion and provide
> sufficient reasons why we have to do it. Cherry-pick is performed
> after the vote passes. So, I suggest that feature and cherry-pick can
> be discussed separately through different emails.
>
> Sincerely,
> Xiangying
>
> On Mon, Sep 25, 2023 at 6:51 PM Zike Yang <zi...@apache.org> wrote:
> >
> > Hi, Zixuan
> >
> > Thanks for your proposal. I'm +1 for it.
> >
> > > This is a feature I need. If cherry-pick is not allowed, then it will
> > only be kept in 3.2+.
> >
> > This is a new feature, and I also think that we couldn't cherry-pick
> > it. What about cherry-picking this change to your fork repo and
> > building the pulsar for your own to meet this need? Does it make sense
> > to you?
> >
> > BR,
> > Zike Yang
> >
> > On Mon, Sep 25, 2023 at 12:23 AM mattison chao <ma...@gmail.com> wrote:
> > >
> > > Hi, Zixuan
> > >
> > > I am afraid I can't support you in cherry-picking this feature for all of the active branches by the current fact. Because this is a new feature and it's not a bug fix or security issue.
> > >
> > > We can wait for other contributor's ideas. WDYT?
> > >
> > > Thanks,
> > > Mattison
> > > On 19 Sep 2023 at 10:42 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > > > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> > > >
> > > > I think we should cherry-pick this PR to Pulsar 2.10, 2.11, 3.0.
> > > >
> > > > > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> > > >
> > > > This is a feature I need. If cherry-pick is not allowed, then it will
> > > > only be kept in 3.2+.
> > > >
> > > > Thanks,
> > > > Zixuan
> > > >
> > > > mattison chao <ma...@gmail.com> 于2023年9月18日周一 09:42写道：
> > > >
> > > > >
> > > > > HI, Zixuan
> > > > >
> > > > > Thanks for your discussion. It's a great feature. But I've got several questions I want to discuss here.
> > > > >
> > > > > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> > > > > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> > > > >
> > > > >
> > > > > Best,
> > > > > Mattison
> > > > > On 12 Sep 2023 at 11:25 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > > > > > BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
> > > > > > > far as I know, the Pulsar 2.10 is a stable/main version, because many
> > > > > > > users are using it.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Zixuan
> > > > > > >
> > > > > > > Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
> > > > > > > > >
> > > > > > > > > Hi Pulsar Community,
> > > > > > > > >
> > > > > > > > > Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by Xiangying Meng <xi...@apache.org>.
Hi Zixuan,
This is really a great feature. I support it.
Regarding cherry-pick, as far as I know, we have cherry-picked some
configuration items and interfaces into branch-2.10.
But that should be mentioned in a separate discussion and provide
sufficient reasons why we have to do it. Cherry-pick is performed
after the vote passes. So, I suggest that feature and cherry-pick can
be discussed separately through different emails.
Sincerely,
Xiangying
On Mon, Sep 25, 2023 at 6:51 PM Zike Yang <zi...@apache.org> wrote:
>
> Hi, Zixuan
>
> Thanks for your proposal. I'm +1 for it.
>
> > This is a feature I need. If cherry-pick is not allowed, then it will
> only be kept in 3.2+.
>
> This is a new feature, and I also think that we couldn't cherry-pick
> it. What about cherry-picking this change to your fork repo and
> building the pulsar for your own to meet this need? Does it make sense
> to you?
>
> BR,
> Zike Yang
>
> On Mon, Sep 25, 2023 at 12:23 AM mattison chao <ma...@gmail.com> wrote:
> >
> > Hi, Zixuan
> >
> > I am afraid I can't support you in cherry-picking this feature for all of the active branches by the current fact. Because this is a new feature and it's not a bug fix or security issue.
> >
> > We can wait for other contributor's ideas. WDYT?
> >
> > Thanks,
> > Mattison
> > On 19 Sep 2023 at 10:42 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> > >
> > > I think we should cherry-pick this PR to Pulsar 2.10, 2.11, 3.0.
> > >
> > > > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> > >
> > > This is a feature I need. If cherry-pick is not allowed, then it will
> > > only be kept in 3.2+.
> > >
> > > Thanks,
> > > Zixuan
> > >
> > > mattison chao <ma...@gmail.com> 于2023年9月18日周一 09:42写道：
> > >
> > > >
> > > > HI, Zixuan
> > > >
> > > > Thanks for your discussion. It's a great feature. But I've got several questions I want to discuss here.
> > > >
> > > > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> > > > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> > > >
> > > >
> > > > Best,
> > > > Mattison
> > > > On 12 Sep 2023 at 11:25 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > > > > BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
> > > > > > far as I know, the Pulsar 2.10 is a stable/main version, because many
> > > > > > users are using it.
> > > > > >
> > > > > > Thanks,
> > > > > > Zixuan
> > > > > >
> > > > > > Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
> > > > > > > >
> > > > > > > > Hi Pulsar Community,
> > > > > > > >
> > > > > > > > Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by Zike Yang <zi...@apache.org>.
Hi, Zixuan
Thanks for your proposal. I'm +1 for it.
> This is a feature I need. If cherry-pick is not allowed, then it will
only be kept in 3.2+.
This is a new feature, and I also think that we couldn't cherry-pick
it. What about cherry-picking this change to your fork repo and
building the pulsar for your own to meet this need? Does it make sense
to you?
BR,
Zike Yang
On Mon, Sep 25, 2023 at 12:23 AM mattison chao <ma...@gmail.com> wrote:
>
> Hi, Zixuan
>
> I am afraid I can't support you in cherry-picking this feature for all of the active branches by the current fact. Because this is a new feature and it's not a bug fix or security issue.
>
> We can wait for other contributor's ideas. WDYT?
>
> Thanks,
> Mattison
> On 19 Sep 2023 at 10:42 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> >
> > I think we should cherry-pick this PR to Pulsar 2.10, 2.11, 3.0.
> >
> > > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> >
> > This is a feature I need. If cherry-pick is not allowed, then it will
> > only be kept in 3.2+.
> >
> > Thanks,
> > Zixuan
> >
> > mattison chao <ma...@gmail.com> 于2023年9月18日周一 09:42写道：
> >
> > >
> > > HI, Zixuan
> > >
> > > Thanks for your discussion. It's a great feature. But I've got several questions I want to discuss here.
> > >
> > > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> > > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> > >
> > >
> > > Best,
> > > Mattison
> > > On 12 Sep 2023 at 11:25 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > > > BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
> > > > > far as I know, the Pulsar 2.10 is a stable/main version, because many
> > > > > users are using it.
> > > > >
> > > > > Thanks,
> > > > > Zixuan
> > > > >
> > > > > Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
> > > > > > >
> > > > > > > Hi Pulsar Community,
> > > > > > >
> > > > > > > Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by mattison chao <ma...@gmail.com>.
Hi, Zixuan
I am afraid I can't support you in cherry-picking this feature for all of the active branches by the current fact. Because this is a new feature and it's not a bug fix or security issue.
We can wait for other contributor's ideas. WDYT?
Thanks,
Mattison
On 19 Sep 2023 at 10:42 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
>
> I think we should cherry-pick this PR to Pulsar 2.10, 2.11, 3.0.
>
> > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
>
> This is a feature I need. If cherry-pick is not allowed, then it will
> only be kept in 3.2+.
>
> Thanks,
> Zixuan
>
> mattison chao <ma...@gmail.com> 于2023年9月18日周一 09:42写道：
>
> >
> > HI, Zixuan
> >
> > Thanks for your discussion. It's a great feature. But I've got several questions I want to discuss here.
> >
> > 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> > 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
> >
> >
> > Best,
> > Mattison
> > On 12 Sep 2023 at 11:25 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > > > BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
> > > > far as I know, the Pulsar 2.10 is a stable/main version, because many
> > > > users are using it.
> > > >
> > > > Thanks,
> > > > Zixuan
> > > >
> > > > Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
> > > > > >
> > > > > > Hi Pulsar Community,
> > > > > >
> > > > > > Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
> > > > > >
> > > > > > Thanks,
> > > > > > Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by Zixuan Liu <no...@gmail.com>.
> 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
I think we should cherry-pick this PR to Pulsar 2.10, 2.11, 3.0.
> 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
This is a feature I need. If cherry-pick is not allowed, then it will
only be kept in 3.2+.
Thanks,
Zixuan
mattison chao <ma...@gmail.com> 于2023年9月18日周一 09:42写道：
>
> HI, Zixuan
>
> Thanks for your discussion. It's a great feature. But I've got several questions I want to discuss here.
>
> 1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
> 2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
>
>
> Best,
> Mattison
> On 12 Sep 2023 at 11:25 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> > BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
> > far as I know, the Pulsar 2.10 is a stable/main version, because many
> > users are using it.
> >
> > Thanks,
> > Zixuan
> >
> > Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
> > >
> > > Hi Pulsar Community,
> > >
> > > Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
> > >
> > > Thanks,
> > > Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by mattison chao <ma...@gmail.com>.
HI, Zixuan
Thanks for your discussion. It's a great feature. But I've got several questions I want to discuss here.
1. When you want to cherry-pick a PR, it should be cherry-picked for all branches after the target branch. Isn't it?
2. I've got a slight concern about cherry-picking. Do you have any issue or feature request in the community that can demonstrate this feature is required to cherry-pick?
Best,
Mattison
On 12 Sep 2023 at 11:25 +0800, Zixuan Liu <no...@gmail.com>, wrote:
> BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
> far as I know, the Pulsar 2.10 is a stable/main version, because many
> users are using it.
>
> Thanks,
> Zixuan
>
> Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
> >
> > Hi Pulsar Community,
> >
> > Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
> >
> > Thanks,
> > Zixuan
Re: [DISCUSS] PIP-300: Add custom dynamic configuration for plugins
Posted by Zixuan Liu <no...@gmail.com>.
BTW, I think we can cherry-pick this feature to the Pulsar 2.10. As
far as I know, the Pulsar 2.10 is a stable/main version, because many
users are using it.
Thanks,
Zixuan
Zixuan Liu <no...@gmail.com> 于2023年9月5日周二 17:09写道：
>
> Hi Pulsar Community,
>
> Discuss for PIP-300: https://github.com/apache/pulsar/pull/21127
>
> Thanks,
> Zixuan