You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 11:04:40 UTC

[GitHub] [airflow] julius-ziegler commented on issue #21089: Scheduler Loading DAGs That Have Not Changed

julius-ziegler commented on issue #21089:
URL: https://github.com/apache/airflow/issues/21089#issuecomment-1033639419


   We also had problems with this and looked at the code a while ago and came to the conclusion that it probably does not work the way it is intended.
   
   It attempts to decide if a file needs to be re-parsed here:
   https://github.com/apache/airflow/blob/39e395f9816c04ef2f033eb0b4f635fc3018d803/airflow/dag_processing/manager.py#L973-L983
   
   But `self.get_last_finish_time()` relies on the `self._file_stats`, but that gets initialized empty in the constructor of `DagFileProcessorManager`:
   
   https://github.com/apache/airflow/blob/39e395f9816c04ef2f033eb0b4f635fc3018d803/airflow/dag_processing/manager.py#L445-L446 
   
   And that I think gets created new on each parsing interval (it would be good if someone else could verify this).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org