You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by ch...@apache.org on 2010/05/21 21:30:50 UTC
svn commit: r947136 - in
/shindig/trunk/features/src/main/javascript/features: core.io/ core.log/
flash/ opensocial-data-context/ opensocial-templates/
opensocial-templates/jsTemplate/ osapi/ rpc/
Author: chirag
Date: Fri May 21 19:30:49 2010
New Revision: 947136
URL: http://svn.apache.org/viewvc?rev=947136&view=rev
Log:
Prevent grammatical and line-break semicolon insertions. Code review: http://codereview.appspot.com/1204044/show
Modified:
shindig/trunk/features/src/main/javascript/features/core.io/io.js
shindig/trunk/features/src/main/javascript/features/core.log/log.js
shindig/trunk/features/src/main/javascript/features/flash/flash.js
shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/util.js
shindig/trunk/features/src/main/javascript/features/osapi/osapi.js
shindig/trunk/features/src/main/javascript/features/rpc/fe.transport.js
shindig/trunk/features/src/main/javascript/features/rpc/nix.transport.js
shindig/trunk/features/src/main/javascript/features/rpc/rmr.transport.js
shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
Modified: shindig/trunk/features/src/main/javascript/features/core.io/io.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/core.io/io.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/core.io/io.js (original)
+++ shindig/trunk/features/src/main/javascript/features/core.io/io.js Fri May 21 19:30:49 2010
@@ -169,7 +169,7 @@ gadgets.io = function() {
};
if (resp.rc < 200 || resp.rc >= 400){
- resp.errors = [resp.rc + " Error"]
+ resp.errors = [resp.rc + " Error"];
} else if (resp.text) {
if (resp.rc >= 300 && resp.rc < 400) {
// Redirect pages will usually contain arbitrary
Modified: shindig/trunk/features/src/main/javascript/features/core.log/log.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/core.log/log.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/core.log/log.js (original)
+++ shindig/trunk/features/src/main/javascript/features/core.log/log.js Fri May 21 19:30:49 2010
@@ -98,7 +98,7 @@ gadgets['setLogLevel'] = function(logLev
}
if (level === warning_ && _console.warn) {
- _console.warn(message)
+ _console.warn(message);
} else if (level === error_ && _console.error) {
_console.error(message);
} else if (_console.log) {
Modified: shindig/trunk/features/src/main/javascript/features/flash/flash.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/flash/flash.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/flash/flash.js (original)
+++ shindig/trunk/features/src/main/javascript/features/flash/flash.js Fri May 21 19:30:49 2010
@@ -159,7 +159,7 @@ gadgets.flash.embedFlash = function(swfU
// use this HTML generation for nefarious purposes.
var propIsHtmlSafe = function(val) {
return !/["<>]/.test(val);
- }
+ };
opt_params.movie = swfUrl;
var attr = {
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js Fri May 21 19:30:49 2010
@@ -222,7 +222,7 @@ opensocial.data.DataContext = function()
* @param {ResponseItem|Object} obj The data object.
*/
putDataSet : function(key, obj) {
- putDataSet(key, obj, true)
+ putDataSet(key, obj, true);
},
/**
@@ -239,7 +239,7 @@ opensocial.data.DataContext = function()
}
fireCallbacks(keys);
}
- }
+ };
}();
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js Fri May 21 19:30:49 2010
@@ -351,7 +351,7 @@ os.copyAttributes_ = function(from, to,
} else if (outName == 'selected' && to.tagName == 'OPTION') {
// For the @selected attribute of an option, set the property
// instead to allow false values to not mark the option selected.
- outName = '.selected'
+ outName = '.selected';
}
// TODO: reuse static array (IE6 perf).
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js Fri May 21 19:30:49 2010
@@ -147,7 +147,7 @@ JsEvalContext.prototype.constructor_ = f
* inherits them in its vars_.
* @type Object
*/
-JsEvalContext.globals_ = {}
+JsEvalContext.globals_ = {};
/**
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js Fri May 21 19:30:49 2010
@@ -177,7 +177,7 @@ function bindFully(object, method, var_a
var args = arraySlice(arguments, 2);
return function() {
return method.apply(object, args);
- }
+ };
}
// Based on <http://www.w3.org/TR/2000/ REC-DOM-Level-2-Core-20001113/
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/util.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/util.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/util.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/util.js Fri May 21 19:30:49 2010
@@ -98,7 +98,7 @@ os.convertToCamelCase = function(str) {
var piece = upper.charAt(index) + words[i].substring(1);
out.push(piece);
}
- index += words[i].length + 1
+ index += words[i].length + 1;
}
return out.join('');
};
Modified: shindig/trunk/features/src/main/javascript/features/osapi/osapi.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/osapi/osapi.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/osapi/osapi.js (original)
+++ shindig/trunk/features/src/main/javascript/features/osapi/osapi.js Fri May 21 19:30:49 2010
@@ -70,5 +70,5 @@
gadgets.warn("Duplicate osapi method definition " + method);
}
last[parts[parts.length - 1]] = apiMethod;
- }
+ };
})();
Modified: shindig/trunk/features/src/main/javascript/features/rpc/fe.transport.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/rpc/fe.transport.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/rpc/fe.transport.js (original)
+++ shindig/trunk/features/src/main/javascript/features/rpc/fe.transport.js Fri May 21 19:30:49 2010
@@ -117,9 +117,9 @@ gadgets.rpctx.frameElement = function()
ready('..', true);
var ackFn = function() {
window.setTimeout(function() {
- gadgets.rpc.call(receiverId, gadgets.rpc.ACK)
+ gadgets.rpc.call(receiverId, gadgets.rpc.ACK);
}, 500);
- }
+ };
// Setup to container always happens before onload.
// If it didn't, the correct fix would be in gadgets.util.
gadgets.util.registerOnLoadHandler(ackFn);
Modified: shindig/trunk/features/src/main/javascript/features/rpc/nix.transport.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/rpc/nix.transport.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/rpc/nix.transport.js (original)
+++ shindig/trunk/features/src/main/javascript/features/rpc/nix.transport.js Fri May 21 19:30:49 2010
@@ -159,7 +159,7 @@ gadgets.rpctx.nix = function() {
if (typeof window[NIX_GET_WRAPPER] !== 'unknown') {
window[NIX_HANDLE_MESSAGE] = function(data) {
window.setTimeout(
- function() { processFn(gadgets.json.parse(data)) }, 0);
+ function() { processFn(gadgets.json.parse(data)); }, 0);
};
window[NIX_CREATE_CHANNEL] = function(name, channel, token) {
Modified: shindig/trunk/features/src/main/javascript/features/rpc/rmr.transport.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/rpc/rmr.transport.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/rpc/rmr.transport.js (original)
+++ shindig/trunk/features/src/main/javascript/features/rpc/rmr.transport.js Fri May 21 19:30:49 2010
@@ -85,10 +85,10 @@ gadgets.rpctx.rmr = function() {
// contentWindow is null, making it impossible to do so.
channelFrame.onload = function() {
processRmrData(opt_frameId);
- }
+ };
}
channelFrame.src = relayUri + '#' + data;
- }
+ };
if (document.body) {
appendFn();
@@ -121,7 +121,7 @@ gadgets.rpctx.rmr = function() {
// The width here is important as RMR
// makes use of the resize handler for the frame.
// Do not modify unless you test thoroughly!
- frameStyle.width = '10px'
+ frameStyle.width = '10px';
frameStyle.height = '1px';
channelFrame.id = 'rmrtransport-' + frameId;
channelFrame.name = channelFrame.id;
Modified: shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js?rev=947136&r1=947135&r2=947136&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/rpc/rpc.js (original)
+++ shindig/trunk/features/src/main/javascript/features/rpc/rpc.js Fri May 21 19:30:49 2010
@@ -122,7 +122,7 @@ gadgets.rpc = function() {
gadgets.json.stringify(Array.prototype.slice.call(arguments)) +
"): call ignored. [caller: " + document.location +
", isChild: " + isChild + "]");
- }
+ };
}
return {
getCode: function() {
@@ -134,7 +134,7 @@ gadgets.rpc = function() {
init: logFn("init"),
setup: logFn("setup"),
call: logFn("call")
- }
+ };
})();
// Load the authentication token for speaking to the container