You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/26 10:33:14 UTC
[GitHub] [spark] codecov-commenter commented on pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf objects for Scala 2.13
codecov-commenter commented on PR #39215:
URL: https://github.com/apache/spark/pull/39215#issuecomment-1365070569
# [Codecov](https://codecov.io/gh/apache/spark/pull/39215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#39215](https://codecov.io/gh/apache/spark/pull/39215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1af0a51) into [master](https://codecov.io/gh/apache/spark/commit/d5865d0c085cc41b39e0d615970bce7da270def6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5865d0) will **decrease** coverage by `46.75%`.
> The diff coverage is `52.50%`.
> :exclamation: Current head 1af0a51 differs from pull request most recent head ad179a1. Consider uploading reports for the commit ad179a1 to get more accurate results
```diff
@@ Coverage Diff @@
## master #39215 +/- ##
===========================================
- Coverage 90.94% 44.18% -46.76%
===========================================
Files 342 171 -171
Lines 76680 40980 -35700
Branches 10462 6478 -3984
===========================================
- Hits 69733 18106 -51627
- Misses 5353 22138 +16785
+ Partials 1594 736 -858
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `44.18% <52.50%> (-46.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/spark/pull/39215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ython/pyspark/sql/connect/proto/expressions\_pb2.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvcHJvdG8vZXhwcmVzc2lvbnNfcGIyLnB5) | `52.32% <0.00%> (ø)` | |
| [python/pyspark/sql/connect/proto/relations\_pb2.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvcHJvdG8vcmVsYXRpb25zX3BiMi5weQ==) | `57.72% <0.00%> (ø)` | |
| [python/pyspark/sql/connect/column.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvY29sdW1uLnB5) | `87.63% <91.66%> (-0.01%)` | :arrow_down: |
| [python/pyspark/sql/connect/dataframe.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvZGF0YWZyYW1lLnB5) | `76.93% <100.00%> (+0.11%)` | :arrow_up: |
| [python/pyspark/sql/connect/expressions.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvZXhwcmVzc2lvbnMucHk=) | `89.05% <100.00%> (-0.07%)` | :arrow_down: |
| [python/pyspark/sql/connect/plan.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvcGxhbi5weQ==) | `80.25% <100.00%> (+0.15%)` | :arrow_up: |
| [python/pyspark/sql/connect/types.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvdHlwZXMucHk=) | `92.00% <100.00%> (+0.16%)` | :arrow_up: |
| [...on/pyspark/sql/tests/connect/test\_connect\_basic.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3Rlc3RzL2Nvbm5lY3QvdGVzdF9jb25uZWN0X2Jhc2ljLnB5) | `99.06% <100.00%> (ø)` | |
| [...n/pyspark/sql/tests/connect/test\_connect\_column.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3Rlc3RzL2Nvbm5lY3QvdGVzdF9jb25uZWN0X2NvbHVtbi5weQ==) | `97.26% <100.00%> (+0.67%)` | :arrow_up: |
| [...l/tests/connect/test\_connect\_column\_expressions.py](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3Rlc3RzL2Nvbm5lY3QvdGVzdF9jb25uZWN0X2NvbHVtbl9leHByZXNzaW9ucy5weQ==) | `97.58% <100.00%> (ø)` | |
| ... and [291 more](https://codecov.io/gh/apache/spark/pull/39215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org