[jira] Updated: (HARMONY-6531) [classlib][luni] URLConnection.getInputStream() does not throw IOException when the socket is closed

["Catherine Hope (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HARMONY-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Catherine Hope updated HARMONY-6531:
------------------------------------

    Attachment: 6531.patch

Fix throws a SocketException if end of stream is reached when getting a server response after requesting an input stream.  The exception is cached so that subsequent calls to getInputStream (and also getContent) will wrap the original exception.  This is in-line with the RI behaviour.

Regression testcase included.

> [classlib][luni] URLConnection.getInputStream() does not throw IOException when the socket is closed
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6531
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6531
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Catherine Hope
>            Priority: Minor
>         Attachments: 6531.patch
>
>
> Calling URLConnection.getInputStream when the socket has been closed returns an input stream that gives -1 when read from.  The RI throws an IOException in this situation:
> DisconnectHttpServer server = new DisconnectHttpServer();
> URLConnection conn = (new URL("http://localhost:" + server.server.getLocalPort())).openConnection();
> server.start();
> conn.connect() // this will be successful, but the sockets will be closed immediately after the connection
> conn.getInputStream();
> class DisconnectHttpServer extends Thread {
>         ServerSocket server = new ServerSocket();
>         DisconnectHttpServer() throws IOException {
>             server.bind(new InetSocketAddress(InetAddress.getByName("localhost"), 0));
>         }
>         public void run() {
>             try {
>                 Socket s = server.accept();
>                 server.close();
>                 s.close();
>             } catch (Exception e) {
>                 e.printStackTrace();
>             }
>         }
>     }
> The stack from the RI is:
> java.net.ConnectException: Connection refused
> 	at java.net.PlainSocketImpl.socketConnect(Native Method)
> 	at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:333)
> 	at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:195)
> 	at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:182)
> 	at java.net.Socket.connect(Socket.java:520)
> 	at java.net.Socket.connect(Socket.java:470)
> 	at sun.net.NetworkClient.doConnect(NetworkClient.java:157)
> 	at sun.net.www.http.HttpClient.openServer(HttpClient.java:388)
> 	at sun.net.www.http.HttpClient.openServer(HttpClient.java:523)
> 	at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:754)
> 	at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:626)
> 	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:974)
> But I'm not sure if we should be attempting a reconnect if end of stream is reached, so I've just fixed it by throwing a SocketException that the socket has been closed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.