You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/08/22 15:12:02 UTC

[PR] Move off the File-based Resolver API [maven-resolver-ant-tasks]

slachiewicz opened a new pull request, #183:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/183

   Clears 18 of the 22 deprecation warnings the build emits, all of them from Resolver 2's File-to-Path migration: `Artifact.getFile`/`setFile`, `Metadata.getFile`, `RepositoryEvent.getFile`, `LocalRepository(File)`, `LocalRepository.getBasedir` and `TransferResource.getTransferStartTime`.
   
   Ant's own types take `File`, so the conversion moves to the edge rather than disappearing. `ProjectWorkspaceReader` now answers `findArtifactPath` and derives `findArtifact` from it, which is the direction Resolver asks in.
   
   A second commit takes `assertThat` from `org.hamcrest.MatcherAssert` instead of the deprecated `org.junit.Assert` alias. It is the same import under either JUnit, so it does not get in the way of #179.
   
   The four warnings left are `org.apache.maven.model.building.ModelSource` in `AntModelResolver`, and they are not ours to fix: `ModelResolver.resolveModel` is declared to return that type, so implementing the interface warns whatever we do. They go away with the model builder, not before.
   
   Verified: `mvn clean verify` → 58 tests, green, and the code warnings drop from 22 to 4; `mvn verify -Prun-its` → green. Transfer throughput and install messages are unchanged in the log, which is what the `TransferResource` and `RepositoryEvent` changes could have broken silently.
   
   Independent of #182; the two touch different parts of `AntRepoSys` and merge either way round.
   
   *This change was created with AI assistance.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move off the File-based Resolver API [maven-resolver-ant-tasks]

Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #183:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org