You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/02 07:13:07 UTC

[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #377: [YUNIKORN-1099] Fix deadlock in Application.notifyRMAllocationReleased()

manirajv06 commented on pull request #377:
URL: https://github.com/apache/incubator-yunikorn-core/pull/377#issuecomment-1056428988


   +1 for the changes.
   
   > I'm not 100% sure a refactoring is needed, but if so, let's do a follow-up JIRA. Despite the similar names, allocations and asks are entirely separate concepts / events and need to be handled discretely.
   
   I am not sure whether I communicated clearly. Just to make it explicit, I meant, application#notifyRMAllocationReleased() and context#notifyRMAllocationReleased() methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org