[GitHub] [flink] godfreyhe commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions

[GitBox <gi...@apache.org>]

godfreyhe commented on issue #9203: [FLINK-13375][table-api] Improve config names in ExecutionConfigOptions and OptimizerConfigOptions
URL: https://github.com/apache/flink/pull/9203#issuecomment-514521764
 
 
   I think readability and extendibility of a config name is more important than strict level. From this point of view, I also tend to align by functionality instead of operator. e.g. `lookup` has `async` and `sync` mode, I think `table.exec.async-lookup.XXX` and `table.exec.sync-lookup.XXX` is more clear than `table.exec.lookup.async-XXX` and `table.exec.lookup.sync-XXX`.
   
   about `enabled`,  I think the readability is almost the same about `table.exec.sort.async-merge.enabled` and `table.exec.sort.async-merge-enabled`, however the extendibility of the first one is better than second one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services