[GitHub] [lucene-solr] dweiss commented on a change in pull request #2235: LUCENE-9690: Hunspell: support special title-case for words with apostrophe

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2235:
URL: https://github.com/apache/lucene-solr/pull/2235#discussion_r563522049



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -138,6 +142,23 @@ WordCase caseOf(char[] word, int length) {
     return lowerBuffer;
   }
 
+  // Special prefix handling for Catalan, French, Italian:

Review comment:
       seems like this can be made static?

##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -138,6 +142,23 @@ WordCase caseOf(char[] word, int length) {
     return lowerBuffer;
   }
 
+  // Special prefix handling for Catalan, French, Italian:

Review comment:
       I'll merge it in, you can piggyback static method on a different PR if you wish.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org