You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2013/01/14 09:37:07 UTC
Review Request: Flume User Guide missing some props for SpoolDirectorySource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
This addresses bug FLUME-1830.
https://issues.apache.org/jira/browse/FLUME-1830
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
Diff: https://reviews.apache.org/r/8941/diff/
Testing
-------
Thanks,
Alexander Alten-Lorenz
Re: Review Request: FLUME-1830: Flume User Guide missing some props for
SpoolDirectorySource
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
> On Jan. 25, 2013, 10:59 a.m., Mike Percy wrote:
> > Hey guys I already submitted FLUME-1800 for this...
Marked FLUME-1830 as dup and discard the request
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/#review15684
-----------------------------------------------------------
On Jan. 24, 2013, 10:48 a.m., Alexander Alten-Lorenz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8941/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 10:48 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
>
>
> This addresses bug FLUME-1830.
> https://issues.apache.org/jira/browse/FLUME-1830
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
>
> Diff: https://reviews.apache.org/r/8941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Alten-Lorenz
>
>
Re: Review Request: FLUME-1830: Flume User Guide missing some props for
SpoolDirectorySource
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/#review15684
-----------------------------------------------------------
Hey guys I already submitted FLUME-1800 for this...
- Mike Percy
On Jan. 24, 2013, 10:48 a.m., Alexander Alten-Lorenz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8941/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 10:48 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
>
>
> This addresses bug FLUME-1830.
> https://issues.apache.org/jira/browse/FLUME-1830
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
>
> Diff: https://reviews.apache.org/r/8941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Alten-Lorenz
>
>
Re: Review Request: FLUME-1830: Flume User Guide missing some props for
SpoolDirectorySource
Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/#review15672
-----------------------------------------------------------
Ship it!
Ship It!
- Juhani Connolly
On Jan. 24, 2013, 10:48 a.m., Alexander Alten-Lorenz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8941/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 10:48 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
>
>
> This addresses bug FLUME-1830.
> https://issues.apache.org/jira/browse/FLUME-1830
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
>
> Diff: https://reviews.apache.org/r/8941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Alten-Lorenz
>
>
Re: Review Request: FLUME-1830: Flume User Guide missing some props for
SpoolDirectorySource
Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/#review15671
-----------------------------------------------------------
Thanks for the patch.
Since the deserializer is configurable, and not all deserializers will use the same properties, is documenting them appropriate?
- Juhani Connolly
On Jan. 24, 2013, 10:48 a.m., Alexander Alten-Lorenz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8941/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 10:48 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
>
>
> This addresses bug FLUME-1830.
> https://issues.apache.org/jira/browse/FLUME-1830
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
>
> Diff: https://reviews.apache.org/r/8941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Alten-Lorenz
>
>
Re: Review Request: FLUME-1830: Flume User Guide missing some props for
SpoolDirectorySource
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8941/
-----------------------------------------------------------
(Updated Jan. 24, 2013, 10:48 a.m.)
Review request for Flume.
Summary (updated)
-----------------
FLUME-1830: Flume User Guide missing some props for SpoolDirectorySource
Description
-------
Flume User Guide is missing these props (along with a description of what they do) that are present in the SpoolDirectorySource and LineDeserializer source file
This addresses bug FLUME-1830.
https://issues.apache.org/jira/browse/FLUME-1830
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 63b8f9b
Diff: https://reviews.apache.org/r/8941/diff/
Testing
-------
Thanks,
Alexander Alten-Lorenz