You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/14 15:36:52 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9531:
Viz py fix try 4
willbarrett opened a new pull request #9531: Viz py fix try 4
URL: https://github.com/apache/incubator-superset/pull/9531
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
https://github.com/apache/incubator-superset/pull/9522 was merged after we finally got CI to pass, but it contained an experimental fix recommended by Max that didn't actually resolve the issue. This PR reverts to the original fix, which does resolve the issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9531: Viz py fix
try 4 (Multi-line chart bug)
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9531: Viz py fix try 4 (Multi-line chart bug)
URL: https://github.com/apache/incubator-superset/pull/9531#issuecomment-613523452
Ha, a typo!
https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9531: Viz py
fix try 4 (Multi-line chart bug)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9531: Viz py fix try 4 (Multi-line chart bug)
URL: https://github.com/apache/incubator-superset/pull/9531#issuecomment-613526529
I'm actually going to wait and see if we actually get a clean build on this branch. No point in doing the update here if it Travis messes up again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed pull request #9531: Viz py
fix try 4 (Multi-line chart bug)
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #9531: Viz py fix try 4 (Multi-line chart bug)
URL: https://github.com/apache/incubator-superset/pull/9531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9531: Viz py fix
try 4 (Multi-line chart bug)
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9531: Viz py fix try 4 (Multi-line chart bug)
URL: https://github.com/apache/incubator-superset/pull/9531#issuecomment-613518657
Oh, that's curious, I thought Max's solution would have fixed it, too. Let me think this through and get back in a second.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9531: Viz py
fix try 4 (Multi-line chart bug)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9531: Viz py fix try 4 (Multi-line chart bug)
URL: https://github.com/apache/incubator-superset/pull/9531#issuecomment-613525874
🤦 updating
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #9531: Viz py
fix try 4 (Multi-line chart bug)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9531: Viz py fix try 4 (Multi-line chart bug)
URL: https://github.com/apache/incubator-superset/pull/9531#issuecomment-613557567
Something is weird with history on this branch, closing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org