[jira] [Updated] (OAK-3523) DefaultSyncContext catches ClassCastException

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-3523:
------------------------
    Labels: technical_debt  (was: )

> DefaultSyncContext catches ClassCastException
> ---------------------------------------------
>
>                 Key: OAK-3523
>                 URL: https://issues.apache.org/jira/browse/OAK-3523
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: angela
>              Labels: technical_debt
>
> the group and group-member sync code in the {{DefaultSyncContext}} twice catches {{ClassCastException}} and swallows exception situations, where a user is found, when actually a {{Group}} was expected.
> i would suggest to 
> - explicitly test the assumption wrt {{ExternalIdentity}} being a group (instead of waiting for the exception)
> - make use of {{UserManager.getAuthorizable(String, Class) to explicitly retrieve a Group with a given ID, when this is actually expected. This method will throws an {{AuthorizableTypeException}} if there exists a {{User}} with that ID as thus properly raise the unexpected behavior instead of swallowing with a log-warning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)