You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2019/12/14 12:28:04 UTC
Translatable diff headers (was: Re: "svn patch" and the TAB character)
Stefan Sperling wrote on Sat, 14 Dec 2019 11:13 +00:00:
> The problem is that svn diff's revision number marker " (revision XY)" must
> be separated by a TAB.
In diff generation, the whole string is translated: _("%s\t(revision
%ld)"). It seems to me that if a translator changed the start of the
string from "%s\t" to anything else, patches would no longer apply,
would they? If so, shouldn't we make just the "(revision %ld)" part
translatable?
Re: Translatable diff headers (was: Re: "svn patch" and the TAB
character)
Posted by Stefan Sperling <st...@elego.de>.
On Sat, Dec 14, 2019 at 12:28:04PM +0000, Daniel Shahaf wrote:
> Stefan Sperling wrote on Sat, 14 Dec 2019 11:13 +00:00:
> > The problem is that svn diff's revision number marker " (revision XY)" must
> > be separated by a TAB.
>
> In diff generation, the whole string is translated: _("%s\t(revision
> %ld)"). It seems to me that if a translator changed the start of the
> string from "%s\t" to anything else, patches would no longer apply,
> would they? If so, shouldn't we make just the "(revision %ld)" part
> translatable?
>
Yes, that would be better indeed.