You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Steve973 (via GitHub)" <gi...@apache.org> on 2024/01/07 22:43:26 UTC
[PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Steve973 opened a new pull request, #12687:
URL: https://github.com/apache/camel/pull/12687
Added control and monitoring per the ticket CAMEL-20302. Updated documentation (javadoc, asciidoc) and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "Steve973 (via GitHub)" <gi...@apache.org>.
Steve973 commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1881745765
Hi, guys. Thanks for being patient while I worked this out. It seems like I always screw up the catalog portion. I also ended up with a few files in here that were unrelated to the work. I looked it over, and it appears to be correct now. I made no changes to the dynamic router component files, but I removed the non-related files, and added the generated catalog file for the dynamic router control component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1882923326
Let's see how it goes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1882946913
> @oscerd and @orpiske hello. Is there anything that I can do that will run the workflows? I understand that you guys are very busy, and I would like to work out any problems before wasting your (and Claus's) time in the future. I see that the workflows require approval from maintainers, but is there anything that I can do? I can run a full build on my own machine, but that always shows extra uncommitted changes that may be entirely unrelated. Are these workflows that I can run in my own fork, and will it give the same results?
Thanks. If the code builds, the tests run successfully and there are no uncommitted change ... that is 90% of the checks from GH CI. So, as long as you are doing that on the PRs, there's a good chance everything's gonna be alright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1880202469
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "Steve973 (via GitHub)" <gi...@apache.org>.
Steve973 commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1882921247
@oscerd and @orpiske hello. Is there anything that I can do that will run the workflows? I understand that you guys are very busy, and I would like to work out any problems before wasting your (and Claus's) time in the future. I see that the workflows require approval from maintainers, but is there anything that I can do? I can run a full build on my own machine, but that always shows extra uncommitted changes that may be entirely unrelated. Are these workflows that I can run in my own fork, and will it give the same results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1884814045
Awesome. Let's merge this. Thanks @Steve973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #12687:
URL: https://github.com/apache/camel/pull/12687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "Steve973 (via GitHub)" <gi...@apache.org>.
Steve973 commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1884763471
Yes, please!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20302: Adding JMX control and monitoring for the Dynamic Router EIP Component [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12687:
URL: https://github.com/apache/camel/pull/12687#issuecomment-1884474078
Hey @Steve973, I believe this is ready to merge. Is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org