You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/27 19:23:12 UTC
[GitHub] [maven-archetype] geoffpotter opened a new pull request, #113: Update CreateArchetypeFromProjectMojo.java
geoffpotter opened a new pull request, #113:
URL: https://github.com/apache/maven-archetype/pull/113
Add "outputDirectory" property so I can change where this puts the generated archetype code from command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add property for outputDirectory in create-from-project mojo [maven-archetype]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #113:
URL: https://github.com/apache/maven-archetype/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #113:
URL: https://github.com/apache/maven-archetype/pull/113#discussion_r1862572028
##########
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java:
##########
@@ -210,7 +210,7 @@ public class CreateArchetypeFromProjectMojo
/**
* The directory where the archetype should be created.
*/
- @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype" )
+ @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype", property = "outputDirectory" )
Review Comment:
I would like to add a prefix `archetype.` like in other parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #113:
URL: https://github.com/apache/maven-archetype/pull/113#discussion_r1862521175
##########
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java:
##########
@@ -210,7 +210,7 @@ public class CreateArchetypeFromProjectMojo
/**
* The directory where the archetype should be created.
*/
- @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype" )
+ @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype", property = "outputDirectory" )
Review Comment:
shouldn't this be the field name by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #113:
URL: https://github.com/apache/maven-archetype/pull/113#discussion_r2078546798
##########
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java:
##########
@@ -210,7 +210,7 @@ public class CreateArchetypeFromProjectMojo
/**
* The directory where the archetype should be created.
*/
- @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype" )
+ @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype", property = "outputDirectory" )
Review Comment:
ok, we have the same property in generate mojo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #113:
URL: https://github.com/apache/maven-archetype/pull/113#discussion_r1862571051
##########
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java:
##########
@@ -210,7 +210,7 @@ public class CreateArchetypeFromProjectMojo
/**
* The directory where the archetype should be created.
*/
- @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype" )
+ @Parameter( defaultValue = "${project.build.directory}/generated-sources/archetype", property = "outputDirectory" )
Review Comment:
no isn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org