You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mbutrovich (via GitHub)" <gi...@apache.org> on 2025/08/26 19:19:48 UTC
[PR] fix: separate type checking for CometExchange and CometColumnarExchange [datafusion-comet]
mbutrovich opened a new pull request, #2241:
URL: https://github.com/apache/datafusion-comet/pull/2241
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Partially addresses #2199.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
CometExchange (native) and CometColumnarExchange support different types for partitioning and serialization, but this is currently not reflected well in the code.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- `supportedSerializableDataType` method for both shuffle types. This enables CometExchange (native) to support serializing deeply nested complex types.
- `supportedPartitioningType` for CometExchange (native). CometColumnarExchange does not get a similar function since if Spark can partition on it, Comet should be able to as well.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: separate type checking for CometExchange and CometColumnarExchange [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on PR #2241:
URL: https://github.com/apache/datafusion-comet/pull/2241#issuecomment-3228969461
Will merge after this latest CI run, then will take a look at #2247.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: separate type checking for CometExchange and CometColumnarExchange [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2241:
URL: https://github.com/apache/datafusion-comet/pull/2241#discussion_r2301927516
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -849,6 +891,41 @@ case class CometExecRule(session: SparkSession) extends Rule[SparkPlan] {
*/
private def columnarShuffleSupported(s: ShuffleExchangeExec): Boolean = {
+ /**
+ * Determine which data types are supported as data columns in native shuffle.
Review Comment:
```suggestion
* Determine which data types are supported as data columns in columnar shuffle.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: separate type checking for CometExchange and CometColumnarExchange [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2241:
URL: https://github.com/apache/datafusion-comet/pull/2241#discussion_r2301931560
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -849,6 +891,41 @@ case class CometExecRule(session: SparkSession) extends Rule[SparkPlan] {
*/
private def columnarShuffleSupported(s: ShuffleExchangeExec): Boolean = {
+ /**
+ * Determine which data types are supported as data columns in native shuffle.
+ *
+ * Comet columnar shuffle used native code to convert Spark unsafe rows to Arrow batches, see
+ * shuffle/row.rs
+ */
+ def supportedSerializableDataType(dt: DataType): Boolean = dt match {
+ case _: BooleanType | _: ByteType | _: ShortType | _: IntegerType | _: LongType |
+ _: FloatType | _: DoubleType | _: StringType | _: BinaryType | _: TimestampType |
+ _: TimestampNTZType | _: DecimalType | _: DateType =>
+ true
+ case StructType(fields) =>
+ fields.forall(f => supportedSerializableDataType(f.dataType)) &&
Review Comment:
We should maybe add a check for `fields.nonEmpty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: separate type checking for CometExchange and CometColumnarExchange [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2241:
URL: https://github.com/apache/datafusion-comet/pull/2241#issuecomment-3225582066
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `42.62295%` with `35 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 33.29%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d9c6884`](https://app.codecov.io/gh/apache/datafusion-comet/commit/d9c6884bf85dc50a6180ba057028d447d7e12372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 415 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/2241?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/scala/org/apache/comet/rules/CometExecRule.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2241?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Frules%2FCometExecRule.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9ydWxlcy9Db21ldEV4ZWNSdWxlLnNjYWxh) | 42.62% | [26 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2241 +/- ##
=============================================
- Coverage 56.12% 33.29% -22.84%
+ Complexity 976 797 -179
=============================================
Files 119 143 +24
Lines 11743 13214 +1471
Branches 2251 2366 +115
=============================================
- Hits 6591 4399 -2192
- Misses 4012 7929 +3917
+ Partials 1140 886 -254
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2241?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: separate type checking for CometExchange and CometColumnarExchange [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich merged PR #2241:
URL: https://github.com/apache/datafusion-comet/pull/2241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org